Summary: | [Gtk] Objects of ATK_ROLE_TABLE should not implement AtkText | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joanmarie Diggs <jdiggs> | ||||||
Component: | Accessibility | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | apinheiro, commit-queue, walker.willie, xan.lopez | ||||||
Priority: | P2 | Keywords: | Gtk | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Linux | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 25531 | ||||||||
Attachments: |
|
Description
Joanmarie Diggs
2010-02-28 14:45:32 PST
Created attachment 49706 [details]
proposed fix
One line fix that seems to solve the problem.
So... How does one write a test to verify that AtkText is *not* implemented? In other words, doesn't testing that tables do not implement AtkText cause the test to fail because AtkText is no longer implemented for tables? :-/
Ideas welcome if this fix must have a test in order to be accepted. Thanks!
Created attachment 49740 [details]
proposed fix with unit test
I was chatting with Xan about this. He provided a way to test that we are no longer implementing AtkText for tables. (Thanks!)
If such a test is worth doing, then I propose this patch; if it's not, I propose the first one. :-) For now, obsoleting the original.
Comment on attachment 49740 [details]
proposed fix with unit test
okay.
Comment on attachment 49740 [details] proposed fix with unit test (In reply to comment #3) > (From update of attachment 49740 [details]) > okay. Thanks! I assume I need to set the commit-queue? flag? Comment on attachment 49740 [details] proposed fix with unit test Clearing flags on attachment: 49740 Committed r56036: <http://trac.webkit.org/changeset/56036> All reviewed patches have been landed. Closing bug. |