Bug 35500

Summary:

[Gtk] Add private browing for plugins for Gtk too

Product:

WebKit

Reporter:

Holger Freyther <zecke>

Component:

Plug-ins

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

gustavo

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Add private browsing for plugins to PluginViewGtk.cpp	gustavo: review+

Holger Freyther

Reported 2010-02-28 13:03:09 PST

In bug #33180 PluginViewQt.cpp got extended to support private browsing for plugins. The bug equally applies to Gtk+. We are already sharing the PluginPackage, we should look into sharing the PluginView as well but it is a bit more difficult.

Attachments
Add private browsing for plugins to PluginViewGtk.cpp (3.09 KB, patch) 2010-02-28 13:11 PST, Holger Freyther	gustavo: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Holger Freyther

Comment 1 2010-02-28 13:11:54 PST

Created attachment 49702 [details] Add private browsing for plugins to PluginViewGtk.cpp This is the same code from PluginViewQt.cpp applied to PluginViewGtk.cpp

Gustavo Noronha (kov)

Comment 2 2010-03-01 14:37:21 PST

Comment on attachment 49702 [details] Add private browsing for plugins to PluginViewGtk.cpp Looks good to me.

Holger Freyther

Comment 3 2010-03-02 02:04:24 PST

Landed in r55405.

Note You need to log in before you can comment on or make changes to this bug.