Summary: | Radio buttons always be in valueMissing state if they are in a form element | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brenton <webkit> | ||||
Component: | Forms | Assignee: | Kent Tamura <tkent> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, adele, darin, tkent | ||||
Priority: | P1 | Keywords: | HTML5 | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Brenton
2010-02-27 01:21:35 PST
Ok, I confirmed. We have a test for radio buttons, but it covers only a case of no <form> element. Created attachment 49682 [details]
Proposed patch
Comment on attachment 49682 [details]
Proposed patch
The style bot failed to catch this spacing error: (yes, I realize you were just moving code)
166 static inline CheckedRadioButtons& checkedRadioButtons(const HTMLInputElement *element)
otherwise looks good.
(In reply to comment #3) > (From update of attachment 49682 [details]) > The style bot failed to catch this spacing error: (yes, I realize you were just > moving code) > 166 static inline CheckedRadioButtons& checkedRadioButtons(const > HTMLInputElement *element) > > otherwise looks good. Ok, I'll fix it and land. Landed as r55640 <http://trac.webkit.org/changeset/55640> |