Bug 35459

Summary:

REGRESSION (r48981): Images do not respect -webkit-user-drag: none

Product:

WebKit

Reporter:

mitz

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

mitz, oliver, victorw, webkit.review.bot

Priority:

Keywords:

InRadar, Regression

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Test case	none
Proposed patch	none
Proposed patch	oliver: review-
Fix a minor style issue in ChangLog	none
Comments removed	none

mitz

Reported 2010-02-26 14:45:10 PST

Created attachment 49649 [details] Test case <http://trac.webkit.org/changeset/48981> (fixing bug 28632) caused images to not respect -webkit-user-drag: none.

Attachments
Test case (105 bytes, text/html) 2010-02-26 14:45 PST, mitz	no flags	Details
Proposed patch (10.33 KB, patch) 2010-02-26 15:55 PST, Victor Wang	no flags	Details Formatted Diff Diff
Proposed patch (10.32 KB, patch) 2010-02-26 16:00 PST, Victor Wang	oliver: review-	Details Formatted Diff Diff
Fix a minor style issue in ChangLog (10.32 KB, patch) 2010-02-26 16:06 PST, Victor Wang	no flags	Details Formatted Diff Diff
Comments removed (9.34 KB, patch) 2010-02-26 16:18 PST, Victor Wang	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

mitz

Comment 1 2010-02-26 14:46:24 PST

<rdar://problem/7696471>

Victor Wang

Comment 2 2010-02-26 15:55:12 PST

Created attachment 49659 [details] Proposed patch Hi Mitz and Oliver, Attached is a patch that I can think of to preserve the behavior prior 48981 which fixes this one and fix bug 28632. Let me know if you know a better solution.

WebKit Review Bot

Comment 3 2010-02-26 15:58:52 PST

Attachment 49659 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/ChangeLog:21: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.

Victor Wang

Comment 4 2010-02-26 16:00:32 PST

Created attachment 49660 [details] Proposed patch

WebKit Review Bot

Comment 5 2010-02-26 16:04:47 PST

Attachment 49660 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/ChangeLog:21: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.

Oliver Hunt

Comment 6 2010-02-26 16:05:58 PST

Comment on attachment 49660 [details] Proposed patch Can you remove the large comment? it is not useful, and in fact makes the code harder to understand. No commen tshould need to be more than 2 lines, if you feel the background you can just refer to this bug. I'm still thinking about the logic of the patch itself.

Victor Wang

Comment 7 2010-02-26 16:06:19 PST

Created attachment 49661 [details] Fix a minor style issue in ChangLog

Victor Wang

Comment 8 2010-02-26 16:18:37 PST

Created attachment 49663 [details] Comments removed

mitz

Comment 9 2010-02-27 04:42:59 PST

Thanks for the patch! I ended up fixing this regression as part of fixing bug 35475, so I am closing this bug.

Eric Seidel (no email)

Comment 10 2010-03-05 15:07:27 PST

Comment on attachment 49663 [details] Comments removed clearing r? on this closed bug.

Note You need to log in before you can comment on or make changes to this bug.