Summary: | [Gtk] Every table, including layout tables, should be exposed as a table | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joanmarie Diggs <jdiggs> | ||||||||
Component: | Accessibility | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | apinheiro, commit-queue, sam, walker.willie, webkit.review.bot, xan.lopez | ||||||||
Priority: | P2 | Keywords: | Gtk | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | Linux | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 25531 | ||||||||||
Attachments: |
|
Description
Joanmarie Diggs
2010-02-25 20:13:27 PST
Created attachment 49562 [details] proposed fix This causes Orca to (for the most part*) do the right thing automatically when a user arrows within the layout table of the Software Center. *Note that when focus is initially given to the table, Orca will speak the entire contents of the table. This is, I believe, due to the problematic table hierarchy (aka bug 30895) which I'll tackle next. Also note that I'm not including a test at this point for a couple of reasons: 1. The most logical type of test for this situation/bug is, I believe, the same sorts of tests being worked on as part of bug 34449. 2. There's no point IMHO in creating a test which will largely need to be changed just as soon as I fix the problematic table hierarchy. Please review. Thanks! Attachment 49562 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/accessibility/gtk/AccessibilityObjectAtk.cpp:55: Should have a space between // and comment [whitespace/comments] [4]
Total errors found: 1 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 49563 [details]
proposed fix - style nit corrected
Added the whitespace to the comment as per the stylebot error.
Please review. Thanks!
Comment on attachment 49563 [details] proposed fix - style nit corrected >+#if PLATFORM(GTK) >+ // Gtk ATs expect all tables, data and layout, to be exposed as tables. >+ if (node && (node->hasTagName(tdTag))) >+ return CellRole; >+ >+ if (node && (node->hasTagName(tableTag))) >+ return TableRole; >+#endif The parenthesis around the second term in each if are not reeded. Other that that looks good, if you can attach a new patch with that detail fixed I'll r+ it. Created attachment 49565 [details] proposed fix - nuke unneed parens > The parenthesis around the second term in each if are not reeded. D'oh! Thank you Xan. :-) > Other that that looks good, if you can attach a new patch with that detail > fixed I'll r+ it. Awesome. I appreciate it. Comment on attachment 49565 [details]
proposed fix - nuke unneed parens
Bam!
Comment on attachment 49565 [details] proposed fix - nuke unneed parens Clearing flags on attachment: 49565 Committed r55297: <http://trac.webkit.org/changeset/55297> All reviewed patches have been landed. Closing bug. This patch was missing a test case. Any reason one could not be provided? (In reply to comment #9) > This patch was missing a test case. Any reason one could not be provided? Please see comment 1. |