Summary: | [Chromium] Chromium doesn't preserve hash fragments on about:blank URLs | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dirk Pranke <dpranke> | ||||
Component: | WebCore JavaScript | Assignee: | Dirk Pranke <dpranke> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | brettw, fishd, ian | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Dirk Pranke
2010-02-25 12:14:52 PST
Created attachment 49518 [details]
Patch
The bug tests whether or not setting a hash fragment on an "about:blank" URL is preserved. There has been some dispute in the past over whether or not we think it should be but current interpretation of <a href="http://www.ietf.org/rfc/rfc3986.txt">RFC 3986</a> is that hash fragments should be honored for all URL types by the browser (even though their interpretation is type-specific). Note that Chromium and FF currently do not preserve this, but WebKit does. Comment on attachment 49518 [details]
Patch
OK.
Instead of mentioning the current behavior of Safari and Chrome in your test, I would simply state what the test does. Since eventually all browsers will pass that test.
You used 2-space indent in your JS.
Fix those nits and land away! :)
|