| Summary: | Qt/Mac: Revert null timer removal (r51105) | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Girish Ramakrishnan <girish> | ||||||
| Component: | Plug-ins | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ap, commit-queue, vestbo | ||||||
| Priority: | P2 | Keywords: | Qt | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | PC | ||||||||
| OS: | OS X 10.5 | ||||||||
| Attachments: |
|
||||||||
|
Description
Girish Ramakrishnan
2010-02-25 10:18:33 PST
First off, I apologize for the lack of time for me in working on this bug (especially since I was the initial committer). That said, I have a patch at http://qt.gitorious.org/~girish/qt/girishs-qt/commit/c8483ce0bdc38ba40a7d673340f6f4f04b7bc439. The patch is known to work (it is more than a simple 'revert' since trunk has changed a bit). If someone has the time, please go ahead and get this committed. PluginViewMac could use a much better name. Looking at this bug, I began to wonder how this change didn't break Safari behavior. Alexey, I think the intent is to make PluginViewMac, the common plugin implementation used across all ports. To be clear : This task is Qt specific. PluginViewMac is not used by Safari. Created attachment 49583 [details] Applying patch suggested by Girish Ramakrishnan in bug comment #1. Attachment 1 looks good to me. Only suggestion I had was to modify the ChangeLog to state why we are reverting it. Created attachment 49586 [details] Applying patch suggested by Girish Ramakrishnan in bug comment #1. Comment on attachment 49586 [details] Applying patch suggested by Girish Ramakrishnan in bug comment #1. LGTM, but it would be nice with an explanation to why that 22 constant is used. It was just moved around in this code, so I won't r- it because of that. Comment on attachment 49586 [details] Applying patch suggested by Girish Ramakrishnan in bug comment #1. Clearing flags on attachment: 49586 Committed r55332: <http://trac.webkit.org/changeset/55332> All reviewed patches have been landed. Closing bug. |