Bug 35396

Summary:

Qt/Mac: Revert null timer removal (r51105)

Product:

WebKit

Reporter:

Girish Ramakrishnan <girish>

Component:

Plug-ins

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, commit-queue, vestbo

Priority:

Keywords:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Applying patch suggested by Girish Ramakrishnan in bug comment #1.	none
Applying patch suggested by Girish Ramakrishnan in bug comment #1.	none

Girish Ramakrishnan

Reported 2010-02-25 10:18:33 PST

r51105 removed the null timer event of the carbon event model. This however breaks the flash of many sites (the ball in http://www.communitymx.com/content/source/E5141/wmodetrans.htm bounces slowly for example).

Attachments
Applying patch suggested by Girish Ramakrishnan in bug comment #1. (6.00 KB, patch) 2010-02-26 07:58 PST, Luiz Agostini	no flags	Details Formatted Diff Diff
Applying patch suggested by Girish Ramakrishnan in bug comment #1. (6.25 KB, patch) 2010-02-26 08:21 PST, Luiz Agostini	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Girish Ramakrishnan

Comment 1 2010-02-25 10:22:16 PST

First off, I apologize for the lack of time for me in working on this bug (especially since I was the initial committer). That said, I have a patch at http://qt.gitorious.org/~girish/qt/girishs-qt/commit/c8483ce0bdc38ba40a7d673340f6f4f04b7bc439. The patch is known to work (it is more than a simple 'revert' since trunk has changed a bit). If someone has the time, please go ahead and get this committed.

Alexey Proskuryakov

Comment 2 2010-02-25 16:03:30 PST

PluginViewMac could use a much better name. Looking at this bug, I began to wonder how this change didn't break Safari behavior.

Girish Ramakrishnan

Comment 3 2010-02-25 18:35:59 PST

Alexey, I think the intent is to make PluginViewMac, the common plugin implementation used across all ports. To be clear : This task is Qt specific. PluginViewMac is not used by Safari.

Luiz Agostini

Comment 4 2010-02-26 07:58:34 PST

Created attachment 49583 [details] Applying patch suggested by Girish Ramakrishnan in bug comment #1.

Girish Ramakrishnan

Comment 5 2010-02-26 08:06:14 PST

Attachment 1 looks good to me. Only suggestion I had was to modify the ChangeLog to state why we are reverting it.

Luiz Agostini

Comment 6 2010-02-26 08:21:13 PST

Created attachment 49586 [details] Applying patch suggested by Girish Ramakrishnan in bug comment #1.

Kenneth Rohde Christiansen

Comment 7 2010-02-26 08:30:56 PST

Comment on attachment 49586 [details] Applying patch suggested by Girish Ramakrishnan in bug comment #1. LGTM, but it would be nice with an explanation to why that 22 constant is used. It was just moved around in this code, so I won't r- it because of that.

WebKit Commit Bot

Comment 8 2010-02-26 18:43:15 PST

Comment on attachment 49586 [details] Applying patch suggested by Girish Ramakrishnan in bug comment #1. Clearing flags on attachment: 49586 Committed r55332: <http://trac.webkit.org/changeset/55332>

WebKit Commit Bot

Comment 9 2010-02-26 18:43:20 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.