Bug 35393

Summary: [Qt] GraphicsLayer: performance optimizations
Product: WebKit Reporter: Noam Rosenthal <noam>
Component: PlatformAssignee: Noam Rosenthal <noam>
Status: CLOSED FIXED    
Severity: Enhancement CC: benjamin, commit-queue, hausmann, vestbo
Priority: P2 Keywords: Performance, Qt
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 35784    
Attachments:
Description Flags
Test case - lots of composited layers, takes longer to render with AC than without
none
Use ItemCoordinateCache and no ItemUsesExtendedStyleOption none

Noam Rosenthal
Reported 2010-02-25 09:42:05 PST
currently all HTML items try to cache themselves. that could lead to a clog if, for example, the root layer is large has some HTML.
Attachments
Test case - lots of composited layers, takes longer to render with AC than without (24.80 KB, text/html)
2010-03-19 06:36 PDT, Noam Rosenthal 		no flags
Details
Use ItemCoordinateCache and no ItemUsesExtendedStyleOption (7.30 KB, patch)
2010-04-15 18:07 PDT, Noam Rosenthal 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tor Arne Vestbø
Comment 1 2010-03-05 09:39:49 PST
Please follow the QtWebKit bug reporting guidelines when reporting bugs. See http://trac.webkit.org/wiki/QtWebKitBugs Specifically: - The 'QtWebKit' component should be used for bugs/features in the public QtWebKit API layer, not to signify that the bug is specific to the Qt port of WebKit http://trac.webkit.org/wiki/QtWebKitBugs#Component
Noam Rosenthal
Comment 2 2010-03-19 06:36:11 PDT
Created attachment 51151 [details] Test case - lots of composited layers, takes longer to render with AC than without
Noam Rosenthal
Comment 3 2010-04-15 18:07:10 PDT
Created attachment 53497 [details] Use ItemCoordinateCache and no ItemUsesExtendedStyleOption This patch aligns our implementation with the CA implementation - everything is cached in item coordinates and caches its full contents.
WebKit Commit Bot
Comment 4 2010-04-16 00:25:30 PDT
Comment on attachment 53497 [details] Use ItemCoordinateCache and no ItemUsesExtendedStyleOption Clearing flags on attachment: 53497 Committed r57718: <http://trac.webkit.org/changeset/57718>
WebKit Commit Bot
Comment 5 2010-04-16 00:25:36 PDT
All reviewed patches have been landed. Closing bug.
Simon Hausmann
Comment 6 2010-04-20 12:08:23 PDT
Revision r57718 cherry-picked into qtwebkit-2.0 with commit 3e5efac4a026ca77206f338434d2e2ee66d24965
Note You need to log in before you can comment on or make changes to this bug.