Summary: | MediaPlayer has no reliable method of accessing it's owning document | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nick Young <nicholas.young> | ||||
Component: | Media | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, eric.carlson | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 35328 | ||||||
Attachments: |
|
Description
Nick Young
2010-02-24 18:13:47 PST
Created attachment 49458 [details]
Initial Patch
Comment on attachment 49458 [details] Initial Patch Clearing flags on attachment: 49458 Committed r55225: <http://trac.webkit.org/changeset/55225> All reviewed patches have been landed. Closing bug. Comment on attachment 49458 [details] Initial Patch > +Document* HTMLMediaElement::mediaPlayerOwningDocument() > +{ > + Document* d = document(); > + > + if (!d) > + d = ownerDocument(); > + > + return d; > +} The implementation of this function is needlessly complex. The Node::document() function never returns 0 for an element, and ownerDocument() always returns the same thing as document() except when ownerDocument() returns 0. |