Bug 35346 – Add a convenient center() method to IntRect

• Component: WebCore Misc.
• Status: CLOSED FIXED

[Antonio Gomes]

FloatRect has the same and according to https://bugs.webkit.org/show_bug.cgi?id=18662#c63
that is something acceptable.

"to make this code more readable. You could also add IntPoint IntRect::center()
const if you like (FloatRect has one)."

patch coming.

[Antonio Gomes]

Created attachment 49399 [details]
patch 0.1

[Simon Fraser (smfr)]

Comment on attachment 49399 [details]
patch 0.1

r=me, but perhaps note in a comment that the center point suffers from rounding.

[Antonio Gomes]

simon, would

+    // NOTE: The result is rounded to integer values, and thus can be not the exact
+    // center point.
+    IntPoint center() const { return IntPoint(x() + width() / 2, y() + height() / 2); }


be ok ?

[Simon Fraser (smfr)]

I'd change: "can be not the exact center point" to "may not be the exact center point".

[Antonio Gomes]

(In reply to comment #4)
> I'd change: "can be not the exact center point" to "may not be the exact center
> point".

landed in r55228

thx simon and kenneth