Bug 35326

Summary: [SPARC] _atomic_word not always an int and WTF_USE_JSVALUE32 needs defining for 64 bit sparc linux
Product: WebKit Reporter: Dennis Gilmore <dgilmore>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: NEW    
Severity: Normal CC: barraclough
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Linux   
Attachments:
Description Flags
patch fixing sparc64 builds none

Dennis Gilmore
Reported 2010-02-23 19:57:48 PST
Created attachment 49353 [details] patch fixing sparc64 builds 64 bit sparc defones _atomic_word as a long due to hardware capabilities. additionally WTF_USE_JSVALUE32 needs to also be defined.
Attachments
patch fixing sparc64 builds (4.80 KB, patch)
2010-02-23 19:57 PST, Dennis Gilmore 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2010-02-25 14:21:08 PST
Would you be willing to submit a patch for review, as documented in <http://webkit.org/coding/contributing.html>?
Dennis Gilmore
Comment 2 2010-02-25 15:24:48 PST
honestly i dont have the time to, its an issue i have fixed at least half a dozen times as the fedora sparc port maintainer. I figured i should submit it upstream for someone to pick up. I have tested it on x86_64 i686 ppc ppc64 sparc and sparc64
Alexey Proskuryakov
Comment 3 2010-02-26 19:39:31 PST
See also: bug 35461, bug 35429. Someone who has access to sparc will need to figure out whether all these three patches are necessary, and make sure that they don't conflict. We are very willing to take patches like these to take the pressure off port maintainers, but someone will need to follow the process and submit them for review.
Gavin Barraclough
Comment 4 2011-08-10 16:21:12 PDT
The platform changes look redundant now, but the use of _Atomic_word is likely valid.
Note You need to log in before you can comment on or make changes to this bug.