Bug 35321

Summary: layout test dashboard json generator pulls the wrong webkit svn revision
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: New BugsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ojan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch eric: review+, eric: commit-queue-

Dirk Pranke
Reported 2010-02-23 17:04:46 PST
layout test dashboard json generator pulls the wrong webkit svn revision
Attachments
Patch (1.49 KB, patch)
2010-02-23 17:06 PST, Dirk Pranke 		eric: review+
eric: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2010-02-23 17:06:17 PST
Created attachment 49344 [details] Patch
Dirk Pranke
Comment 2 2010-02-23 17:07:29 PST
Ojan, can you take a look at this and make sure it looks right?
Ojan Vafai
Comment 3 2010-02-23 17:32:47 PST
Comment on attachment 49344 [details] Patch Looks right to me. Nit: You might want to add to the ChangeLog description that we need to do this because Chromium doens't checkout the WebKit directory, just the subdirectories. That way it's in the revision history why we're getting the WebCore revision.
Dirk Pranke
Comment 4 2010-02-23 17:35:38 PST
will do.
Eric Seidel (no email)
Comment 5 2010-02-24 12:24:16 PST
Comment on attachment 49344 [details] Patch This could easily be moved to the (unit tested) scm.py module and suddenly support both git and svn repositories. But this change as-is looks OK for now too. cq- for ojan's nit.
Dirk Pranke
Comment 6 2010-02-24 14:48:17 PST
Fix committed as r55202. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.