| Summary: | Web Inspector: Activate/Deactivate breaks does not look consistent with rest of the toolbar. | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Pavel Feldman <pfeldman> | ||||||||||
| Component: | Web Inspector (Deprecated) | Assignee: | Alexander Pavlov (apavlov) <apavlov> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | apavlov, timothy | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | All | ||||||||||||
| OS: | All | ||||||||||||
| Attachments: |
|
||||||||||||
I thought we landed without color? (In reply to comment #1) > I thought we landed without color? I thought so and was surprised with the looks. Hence the bug report. What about the glyph? It looks 1px too south, but it is really the breakpoint height to blame. Needs to be 1px higher (as Pause). Created attachment 49370 [details]
[IMAGE] glyph1 (as if I was xenon).
Created attachment 49371 [details]
[IMAGE] glyph2 (as if I was xenon).
Those glyphs look fine to me. Created attachment 49377 [details]
[PATCH] Proposed solution
Committed with the images added into WebCore.gypi + WebKit.qrc. Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/WebCore.gypi M WebCore/inspector/front-end/Images/deactivateBreakpointsButtonGlyph.png M WebCore/inspector/front-end/Images/deactivateBreakpointsDisabledButtonGlyph.png M WebCore/inspector/front-end/WebKit.qrc M WebCore/inspector/front-end/inspector.css Committed r55187 |
Created attachment 49311 [details] [IMAGE] Present looks. 1) It should lose its color 2) Seems like glyph should be 1px higher for the sake of symmetry