Bug 35307

Summary: Web Inspector: Activate/Deactivate breaks does not look consistent with rest of the toolbar.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Alexander Pavlov (apavlov) <apavlov>
Severity: Normal CC: apavlov, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Description Flags
[IMAGE] Present looks.
[IMAGE] glyph1 (as if I was xenon).
[IMAGE] glyph2 (as if I was xenon).
[PATCH] Proposed solution pfeldman: review+

Description Pavel Feldman 2010-02-23 11:36:21 PST
Created attachment 49311 [details]
[IMAGE] Present looks.

1) It should lose its color
2) Seems like glyph should be 1px higher for the sake of symmetry
Comment 1 Timothy Hatcher 2010-02-23 11:38:42 PST
I thought we landed without color?
Comment 2 Pavel Feldman 2010-02-23 12:26:04 PST
(In reply to comment #1)
> I thought we landed without color?

I thought so and was surprised with the looks. Hence the bug report. What about the glyph? It looks 1px too south, but it is really the breakpoint height to blame. Needs to be 1px higher (as Pause).
Comment 3 Pavel Feldman 2010-02-24 02:39:50 PST
Created attachment 49370 [details]
[IMAGE] glyph1 (as if I was xenon).
Comment 4 Pavel Feldman 2010-02-24 02:40:32 PST
Created attachment 49371 [details]
[IMAGE] glyph2 (as if I was xenon).
Comment 5 Timothy Hatcher 2010-02-24 03:38:24 PST
Those glyphs look fine to me.
Comment 6 Alexander Pavlov (apavlov) 2010-02-24 04:06:27 PST
Created attachment 49377 [details]
[PATCH] Proposed solution
Comment 7 Alexander Pavlov (apavlov) 2010-02-24 05:22:09 PST
Committed with the images added into WebCore.gypi + WebKit.qrc.

Committing to http://svn.webkit.org/repository/webkit/trunk ...
        M       WebCore/ChangeLog
        M       WebCore/WebCore.gypi
        M       WebCore/inspector/front-end/Images/deactivateBreakpointsButtonGlyph.png
        M       WebCore/inspector/front-end/Images/deactivateBreakpointsDisabledButtonGlyph.png
        M       WebCore/inspector/front-end/WebKit.qrc
        M       WebCore/inspector/front-end/inspector.css
Committed r55187