Bug 35307

Summary:

Web Inspector: Activate/Deactivate breaks does not look consistent with rest of the toolbar.

Product:

WebKit

Reporter:

Pavel Feldman <pfeldman>

Component:

Web Inspector (Deprecated)

Assignee:

Alexander Pavlov (apavlov) <apavlov>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, timothy

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[IMAGE] Present looks.	none
[IMAGE] glyph1 (as if I was xenon).	none
[IMAGE] glyph2 (as if I was xenon).	none
[PATCH] Proposed solution	pfeldman: review+

Pavel Feldman

Reported 2010-02-23 11:36:21 PST

Created attachment 49311 [details] [IMAGE] Present looks. 1) It should lose its color 2) Seems like glyph should be 1px higher for the sake of symmetry

Attachments
[IMAGE] Present looks. (6.36 KB, image/png) 2010-02-23 11:36 PST, Pavel Feldman	no flags	Details
[IMAGE] glyph1 (as if I was xenon). (250 bytes, image/png) 2010-02-24 02:39 PST, Pavel Feldman	no flags	Details
[IMAGE] glyph2 (as if I was xenon). (426 bytes, image/png) 2010-02-24 02:40 PST, Pavel Feldman	no flags	Details
[PATCH] Proposed solution (3.46 KB, patch) 2010-02-24 04:06 PST, Alexander Pavlov (apavlov)	pfeldman: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Timothy Hatcher

Comment 1 2010-02-23 11:38:42 PST

I thought we landed without color?

Pavel Feldman

Comment 2 2010-02-23 12:26:04 PST

(In reply to comment #1) > I thought we landed without color? I thought so and was surprised with the looks. Hence the bug report. What about the glyph? It looks 1px too south, but it is really the breakpoint height to blame. Needs to be 1px higher (as Pause).

Pavel Feldman

Comment 3 2010-02-24 02:39:50 PST

Created attachment 49370 [details] [IMAGE] glyph1 (as if I was xenon).

Pavel Feldman

Comment 4 2010-02-24 02:40:32 PST

Created attachment 49371 [details] [IMAGE] glyph2 (as if I was xenon).

Timothy Hatcher

Comment 5 2010-02-24 03:38:24 PST

Those glyphs look fine to me.

Alexander Pavlov (apavlov)

Comment 6 2010-02-24 04:06:27 PST

Created attachment 49377 [details] [PATCH] Proposed solution

Alexander Pavlov (apavlov)

Comment 7 2010-02-24 05:22:09 PST

Committed with the images added into WebCore.gypi + WebKit.qrc. Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/WebCore.gypi M WebCore/inspector/front-end/Images/deactivateBreakpointsButtonGlyph.png M WebCore/inspector/front-end/Images/deactivateBreakpointsDisabledButtonGlyph.png M WebCore/inspector/front-end/WebKit.qrc M WebCore/inspector/front-end/inspector.css Committed r55187

Note You need to log in before you can comment on or make changes to this bug.