Bug 35306
| Summary: | When the WebInspector window can't dock because the host window is too small, the dock button should be disabled. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Brady Eidson <beidson> |
| Component: | Web Inspector (Deprecated) | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | burg |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
Brady Eidson
When the WebInspector window can't dock because the host window is too small, the dock button should be disabled.
Spun out of discussion from https://bugs.webkit.org/show_bug.cgi?id=35274 and will be needed as a followup to that fix.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Brady Eidson
Causes a layouttest failure
--- /tmp/layout-test-results/inspector/timeline-event-dispatch-expected.txt 2010-02-23 11:40:48.000000000 -0800
+++ /tmp/layout-test-results/inspector/timeline-event-dispatch-actual.txt 2010-02-23 11:40:48.000000000 -0800
@@ -1,12 +1,4 @@
Tests the Timeline API instrumentation of a DOM Dispatch (mousedown)
Test Mouse Target
-EventDispatch Properties:
-+ startTime : * DEFINED *
-+ data : {
-+- type : mousedown
-+ }
-+ children : * DEFINED *
-+ endTime : * DEFINED *
-+ type : 0
Brady Eidson
Whoops, wrong bug.
Brady Eidson
My gut reaction was to have inspector.js just listen for the resize event from the inspected window, but there's no way to do that.
We'd either:
A - have to find a way to get the browser window's resize event passed to an undocked inspector window
or
B - add native code to WebCore that calls out to the web inspector when a resize event for the browser window should cause the "enabled" state of the dock button to change.