Bug 35240

Summary:

[Qt] Enable to use built-product-archive on Qt platform

Product:

WebKit

Reporter:

Gabor Rapcsanyi <rgabor>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, abecsi, darin, mrowe, ossy, vestbo, webkit.review.bot, zoltan

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Attachments:

Description	Flags
proposed patch	vestbo: review-
fixed patch	none
fixed patch 2	kenneth: review+

Gabor Rapcsanyi

Reported 2010-02-22 07:09:11 PST

Implement the Qt platform in built-product-archive script.

Attachments
proposed patch (2.72 KB, patch) 2010-02-22 07:10 PST, Gabor Rapcsanyi	vestbo: review-	Details Formatted Diff Diff
fixed patch (5.76 KB, patch) 2010-02-24 06:33 PST, Gabor Rapcsanyi	no flags	Details Formatted Diff Diff
fixed patch 2 (2.82 KB, patch) 2010-02-24 06:39 PST, Gabor Rapcsanyi	kenneth: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Gabor Rapcsanyi

Comment 1 2010-02-22 07:10:35 PST

Created attachment 49215 [details] proposed patch

Tor Arne Vestbø

Comment 2 2010-02-24 03:55:19 PST

Comment on attachment 49215 [details] proposed patch This patch seems to have indentation issues

Gabor Rapcsanyi

Comment 3 2010-02-24 06:33:28 PST

Created attachment 49386 [details] fixed patch

WebKit Review Bot

Comment 4 2010-02-24 06:35:48 PST

Attachment 49386 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 Total errors found: 0 in 0 files If any of these errors are false positives, please file a bug against check-webkit-style.

Gabor Rapcsanyi

Comment 5 2010-02-24 06:39:09 PST

Created attachment 49387 [details] fixed patch 2

Adam Barth

Comment 6 2010-02-24 11:57:40 PST

> Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 > Total errors found: 0 in 0 files Strange.

Kenneth Rohde Christiansen

Comment 7 2010-03-04 04:29:35 PST

Comment on attachment 49387 [details] fixed patch 2 r=me, but one question though, how does this code diverge from the windows and mac code? Shouldn't it be really similar?

Csaba Osztrogonác

Comment 8 2010-03-04 04:56:24 PST

Landed in http://trac.webkit.org/changeset/55519 . There are some reason why we need different code to archive and extract files. First, Mac uses ditto which is available on Mac OS only. And Mac, Win, Qt build directory structure, name, etc. are different from each other, that's why we needed this patch.

Note You need to log in before you can comment on or make changes to this bug.