Bug 35235

Summary: [check-webkit-style] whitespace/declaration false positive.
Product: WebKit Reporter: Leandro Pereira <leandro>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Enhancement CC: cjerdonek, commit-queue, eric, hamaji, levin, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed patch
none
Proposed patch
eric: review-
Proposed patch, with requested test case none

Description Leandro Pereira 2010-02-22 05:31:07 PST 
In statements like:

   delete *ptr;

check-webkit-style reports a 'whitespace/declaration' error, which is wrong. Forthcoming patch fixes this.
Comment 1 Leandro Pereira 2010-02-22 05:32:03 PST 
Created attachment 49204 [details]
Proposed patch
Comment 2 WebKit Review Bot 2010-02-22 05:32:41 PST 
Attachment 49204 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKitTools/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Leandro Pereira 2010-02-22 05:34:45 PST 
Created attachment 49205 [details]
Proposed patch

Fixed style (removed stray tab from ChangeLog).
Comment 4 Eric Seidel (no email) 2010-02-22 14:35:48 PST 
Comment on attachment 49205 [details]
Proposed patch

Needs a unit test.  Otherwise this looks good.

r- for lack of test.
Comment 5 Leandro Pereira 2010-02-23 05:26:30 PST 
Created attachment 49281 [details]
Proposed patch, with requested test case
Comment 6 Shinichiro Hamaji 2010-02-23 07:10:56 PST 
Comment on attachment 49281 [details]
Proposed patch, with requested test case

Looks good. Thanks for the fix!
Comment 7 WebKit Commit Bot 2010-02-23 07:28:26 PST 
Comment on attachment 49281 [details]
Proposed patch, with requested test case

Clearing flags on attachment: 49281

Committed r55151: <http://trac.webkit.org/changeset/55151>
Comment 8 WebKit Commit Bot 2010-02-23 07:28:31 PST 
All reviewed patches have been landed.  Closing bug.