Bug 35178

Summary:

LiveConnect code uses hand-rolled fprintf logging

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

Java

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Trivial

CC:

webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
proposed fix	ggaren: review+

Description Alexey Proskuryakov 2010-02-19 14:34:46 PST

As a result, debug builds get very noisy whenever a Java applet is loaded.

Comment 1 Alexey Proskuryakov 2010-02-19 14:54:14 PST

*** Bug 35179 has been marked as a duplicate of this bug. ***

Comment 2 Alexey Proskuryakov 2010-02-19 15:10:58 PST

Created attachment 49106 [details]
proposed fix

Comment 3 WebKit Review Bot 2010-02-19 15:11:53 PST

Attachment 49106 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/platform/text/gtk/TextCodecGtk.cpp:257:  Missing space before ( in if(  [whitespace/parens] [5]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 4 Geoffrey Garen 2010-02-19 15:12:36 PST

Comment on attachment 49106 [details]
proposed fix

r=me

Comment 5 Alexey Proskuryakov 2010-02-19 15:46:01 PST

Committed revision 55036.