| Summary: | [Chromium] autofill should not be shown for read only text fields | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jay Campan <jcampan> | ||||||||
| Component: | WebKit API | Assignee: | Jay Campan <jcampan> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, levin, webkit.review.bot | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | OS X 10.5 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Jay Campan
2010-02-18 13:31:56 PST
Created attachment 49039 [details]
Bug fix patch
Comment on attachment 49039 [details]
Bug fix patch
We can write a manual test for this, no? Should go in WebCore/manual-tests/
Created attachment 49403 [details]
Adding a manual test.
Added a manual test in WebCore/manual-tests/chromium.
Attachment 49403 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/manual-tests/chromium/no-autofill-on-readonly.html:1: One or more unexpected \r (^M) found; better to use only a \n [whitespace/carriage_return] [1]
Suppressing further [whitespace/carriage_return] reports for this file.
Total errors found: 32 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 49403 [details]
Adding a manual test.
r=me except for the style issue and since you aren't a committer r- to fix that up.
Created attachment 49411 [details]
Fixed bad line endings
Comment on attachment 49411 [details] Fixed bad line endings Clearing flags on attachment: 49411 Committed r55219: <http://trac.webkit.org/changeset/55219> All reviewed patches have been landed. Closing bug. |