Bug 35098

Summary: Debugging WebKit on Windows should mention WebKit.sln as an alternative to running debug-safari
Product: WebKit Reporter: Jessie Berlin <jberlin>
Component: WebKit WebsiteAssignee: Jessie Berlin <jberlin>
Status: RESOLVED FIXED    
Severity: Enhancement CC: aroben, eric, jberlin, sfalken
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
URL: http://webkit.org/building/debug.html
Attachments:
Description Flags
Add information to the webkit.org debugging page about using WebKit.sln with Visual Studio aroben: review+

Description Jessie Berlin 2010-02-18 07:06:30 PST
I find it much easier to debug and work on WebKit for Windows inside Visual Studio by opening the WebKit.sln file inside of Visual Studio instead of running debug-safari, as is currently suggested on the Debugging WebKit page, and have been suggesting that approach when I help others get setup on Windows.

We should add this suggestion to the Debugging WebKit page.
Comment 1 Jessie Berlin 2010-02-20 13:40:23 PST
Created attachment 49133 [details]
Add information to the webkit.org debugging page about using WebKit.sln with Visual Studio
Comment 2 Eric Seidel (no email) 2010-02-22 14:08:15 PST
Comment on attachment 49133 [details]
Add information to the webkit.org debugging page about using WebKit.sln with Visual Studio

OK.  Looks about right.  rs=me.
Comment 3 Adam Roben (:aroben) 2010-02-22 14:17:58 PST
Comment on attachment 49133 [details]
Add information to the webkit.org debugging page about using WebKit.sln with Visual Studio

I believe these steps will only work if you've set the WEBKITOUTPUTDIR and WEBKITLIBRARIESDIR environment variables, as mentioned at <http://trac.webkit.org/wiki/BuildingOnWindows#BuildingfromwithinVisualStudio>. Seems like we need to mention that.
Comment 4 Jessie Berlin 2010-02-22 15:12:26 PST
(In reply to comment #3)
> (From update of attachment 49133 [details])
> I believe these steps will only work if you've set the WEBKITOUTPUTDIR and
> WEBKITLIBRARIESDIR environment variables, as mentioned at
> <http://trac.webkit.org/wiki/BuildingOnWindows#BuildingfromwithinVisualStudio>.
> Seems like we need to mention that.

Even though they are now set automatically when you run update-webkit? (http://trac.webkit.org/changeset/519328)
Comment 5 Adam Roben (:aroben) 2010-02-22 15:19:31 PST
(In reply to comment #4)
> (In reply to comment #3)
> > (From update of attachment 49133 [details] [details])
> > I believe these steps will only work if you've set the WEBKITOUTPUTDIR and
> > WEBKITLIBRARIESDIR environment variables, as mentioned at
> > <http://trac.webkit.org/wiki/BuildingOnWindows#BuildingfromwithinVisualStudio>.
> > Seems like we need to mention that.
> 
> Even though they are now set automatically when you run update-webkit?
> (http://trac.webkit.org/changeset/519328)

I had forgotten about that! I guess I'm stuck in the past. (I think you meant <http://trac.webkit.org/changeset/51932>.)

Someone should update the wiki page.
Comment 6 Jessie Berlin 2010-02-23 13:51:21 PST
(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #3)
> > > (From update of attachment 49133 [details] [details] [details])
> > > I believe these steps will only work if you've set the WEBKITOUTPUTDIR and
> > > WEBKITLIBRARIESDIR environment variables, as mentioned at
> > > <http://trac.webkit.org/wiki/BuildingOnWindows#BuildingfromwithinVisualStudio>.
> > > Seems like we need to mention that.
> > 
> > Even though they are now set automatically when you run update-webkit?
> > (http://trac.webkit.org/changeset/519328)
> 
> I had forgotten about that! I guess I'm stuck in the past. (I think you meant
> <http://trac.webkit.org/changeset/51932>.)
> 
> Someone should update the wiki page.

Which wiki page? The BuildingOnWindows page already has this comment:

"Building from within Visual Studio

WebKit can be built from within Visual Studio by setting two environment variables:

WEBKITOUTPUTDIR - An absolute Windows-style path pointing to the directory where you want the build products to go.
WEBKITLIBRARIESDIR - An absolute Windows-style path pointing to the WebKitLibraries/win folder in your WebKit checkout.

These environment variables should be set for you the first time you run update-webkit."
Comment 7 Adam Roben (:aroben) 2010-02-23 13:58:39 PST
(In reply to comment #6)
> (In reply to comment #5)
> > Someone should update the wiki page.
> 
> Which wiki page? The BuildingOnWindows page already has this comment:
> 
> "Building from within Visual Studio
> 
> WebKit can be built from within Visual Studio by setting two environment
> variables:
> 
> WEBKITOUTPUTDIR - An absolute Windows-style path pointing to the directory
> where you want the build products to go.
> WEBKITLIBRARIESDIR - An absolute Windows-style path pointing to the
> WebKitLibraries/win folder in your WebKit checkout.
> 
> These environment variables should be set for you the first time you run
> update-webkit."

Yeah, I updated it after writing comment 5. Sorry for not saying so.
Comment 8 Jessie Berlin 2010-02-23 14:09:45 PST
Committed in r55170 (http://trac.webkit.org/changeset/55170)