Bug 35090 – Need -webkit-focus-inner to control the style of buttons

• Component: CSS
• Status: RESOLVED WONTFIX

[Shinichiro Hamaji]

With Firefox, we can change the style of anonymous render blocks in buttons using -moz-focus-inner pseudo element.

This would be especially useful for Chrome because its buttons have some paddings to match the behavior of Firefox and currently there are no way to disable the paddings. See Bug 24048 for detail.

The chromium bug for this issue: http://crbug.com/1437

[Shinichiro Hamaji]

Created attachment 48999 [details]
Patch v1

[Shinichiro Hamaji]

I added baseStyle parameter for CSSStyleSelector::pseudoStyleForElement and this would be the most tricky point of my patch. We cannot use the existing parameter parentStyle because paddings aren't inherited.

I think this solution isn't so bad, but I'm not 100% sure if this is the best. Any kind of suggestions will be really appreciated :)

[Adam Barth]

Comment on attachment 48999 [details]
Patch v1

Your ChangeLog doesn't give any information about this change.

I didn't understand why this part was necessary:

-void RenderButton::setupInnerStyle(RenderStyle* innerStyle) 
+void RenderButton::setupInnerStyle()

This patch has been up for review for over a month with no discussion.

Why do we want to implement this non-standard feature?  Doesn't that just serve to fragment the web platform?  Is this a feature that we'd like to see standardized at some point?

[Shinichiro Hamaji]

The internal padding has gone so we don't need to provide a way to adjust it.

https://bugs.webkit.org/show_bug.cgi?id=38016