Summary: | keyboard selection sometimes moves the wrong end of the selection for Win/Linux | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ojan Vafai <ojan> | ||||
Component: | HTML Editing | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | darin, eric, evan, tonikitoo, tony | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Windows XP | ||||||
Attachments: |
|
Description
Ojan Vafai
2010-02-17 18:19:59 PST
Created attachment 48957 [details]
Patch
Comment on attachment 48957 [details]
Patch
I applaud your thorough testing.
Everyone seems really excited about this patch and the mechanics seem straightforward enough.
I'm not an editing expert, so please let me know if you'd rather I didn't review editing patches in the future.
+// FIXME: Expose settings->editingBehavior() and use that here instead. +var onMacPlatform = navigator.userAgent.search(/\bMac OS X\b/) != -1; I wonder if this will fail on iPhone. I wonder if iPhones use Mac editing behavior. I guess there's no shift-home on iPhones. :) I wonder if we run tests on iPhones? (In reply to comment #3) > +// FIXME: Expose settings->editingBehavior() and use that here instead. > +var onMacPlatform = navigator.userAgent.search(/\bMac OS X\b/) != -1; > > I wonder if this will fail on iPhone. > I wonder if iPhones use Mac editing behavior. > I guess there's no shift-home on iPhones. :) > I wonder if we run tests on iPhones? The iPhone user agent has Mac OS X in it so this should be fine. This would matter for an iPad with a keyboard. Committed r54980: <http://trac.webkit.org/changeset/54980> |