Bug 35066 – keyboard selection sometimes moves the wrong end of the selection for Win/Linux

• Component: HTML Editing
• Status: RESOLVED FIXED

[Ojan Vafai]

Given the following text:
line one
line two
line three

1. Put the cursor in the middle of line one.
2. Shift+down
3. Shift+home
4. Shift+end

On Win/Linux, you should see the word "one" selected after 3. And the words "one" and "line two" selected after 4. Instead "line " (in line 1) is selected after 3 and "one" is selected after 4.

[Ojan Vafai]

Created attachment 48957 [details]
Patch

[Adam Barth]

Comment on attachment 48957 [details]
Patch

I applaud your thorough testing.

Everyone seems really excited about this patch and the mechanics seem straightforward enough.

I'm not an editing expert, so please let me know if you'd rather I didn't review editing patches in the future.

[Evan Martin]

+// FIXME: Expose settings->editingBehavior() and use that here instead.
+var onMacPlatform = navigator.userAgent.search(/\bMac OS X\b/) != -1;

I wonder if this will fail on iPhone.
I wonder if iPhones use Mac editing behavior.
I guess there's no shift-home on iPhones.  :)
I wonder if we run tests on iPhones?

[Tony Chang]

(In reply to comment #3)
> +// FIXME: Expose settings->editingBehavior() and use that here instead.
> +var onMacPlatform = navigator.userAgent.search(/\bMac OS X\b/) != -1;
> 
> I wonder if this will fail on iPhone.
> I wonder if iPhones use Mac editing behavior.
> I guess there's no shift-home on iPhones.  :)
> I wonder if we run tests on iPhones?

The iPhone user agent has Mac OS X in it so this should be fine.  This would matter for an iPad with a keyboard.

[Ojan Vafai]

Committed r54980: <http://trac.webkit.org/changeset/54980>