| Summary: | Delay between page loading and animated GIF playing | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Rowe (bdash) <mrowe> | ||||
| Component: | Images | Assignee: | Peter Kasting <pkasting> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | mrowe, pkasting | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | OS X 10.6 | ||||||
| URL: | http://i.imgur.com/Zgc5p.gif | ||||||
| Bug Depends on: | 35115 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Mark Rowe (bdash)
2010-02-17 17:56:50 PST
Created attachment 48955 [details]
Patch v1
This appears to address the issue.
CCing Mr Peter Kasting as he did a lot of work on this code back in the day. The old code was definitely way wrong. Thanks for fixing! The new patch has a small bug: the first time through, when the desired frame start time is zero, we should set the desired start time immediately. Otherwise the GIF start lags by the amount of time needed to decode the second frame. This is minor, but can make a difference on sites like YTMND. I'll write a patch for this. Comment on attachment 48955 [details]
Patch v1
Clearing flags on this patch, as it has landed.
(In reply to comment #4) > The old code was definitely way wrong. Thanks for fixing! > > The new patch has a small bug: the first time through, when the desired frame > start time is zero, we should set the desired start time immediately. > Otherwise the GIF start lags by the amount of time needed to decode the second > frame. This is minor, but can make a difference on sites like YTMND. I'll > write a patch for this. Please file a new bug. That’s clearly a different issue than what this bug was about, so repurposing it for that doesn’t seem sensible. |
