Summary: | windowless plugins don't get button press events for right mouse button | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brian Tarricone <bjt23> | ||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED DUPLICATE | ||||||||
Severity: | Normal | ||||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Linux | ||||||||
Attachments: |
|
Description
Brian Tarricone
2010-02-17 17:45:38 PST
Created attachment 48958 [details]
don't drop right mouse press events if the frame doesn't handle them
Ok, I think I figured it out. The gtk WebKitWebView button-press-event handler was dropping the right press if EventHandler::sendContextMenuEvent() chose not to handle the event (which is the case when you right-click over a windowless plugin). I *think* the correct behavior is that the button-press-event handler should handle the event as usual if webkit_web_view_forward_context_menu_event() returns FALSE. This patch does just that.
Created attachment 48959 [details]
previous patch + style fix
Of course I notice the style issue *right* after I click submit. Fixed.
Comment on attachment 48959 [details] previous patch + style fix hmm, so, this is related to this other patch: https://bugs.webkit.org/show_bug.cgi?id=29177 Can you test if that patch fixes the issue for you? It would be good to add layout testing to this. |