Bug 35047

Summary:

Database.transaction() should accept nulls for optional parameters

Product:

WebKit

Reporter:

Dumitru Daniliuc <dumi>

Component:

New Bugs

Assignee:

Dumitru Daniliuc <dumi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, michaeln

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch	dumi: commit-queue-
patch	dglazkov: review+, dumi: commit-queue-

Dumitru Daniliuc

Reported 2010-02-17 11:50:01 PST

Database.transaction() complains when 'null' is used for the transaction success or error callback. It should be treated as "no callback specified".

Attachments
patch (1.64 KB, patch) 2010-02-17 12:03 PST, Dumitru Daniliuc	dumi: commit-queue-	Details Formatted Diff Diff
patch (4.26 KB, patch) 2010-02-17 13:15 PST, Dumitru Daniliuc	dglazkov: review+ dumi: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Dumitru Daniliuc

Comment 1 2010-02-17 12:03:51 PST

Created attachment 48921 [details] patch The JSC bindings know how to deal with null callbacks. Only Chromium's bindings needed to be fixed.

Dumitru Daniliuc

Comment 2 2010-02-17 13:15:35 PST

Dimitri Glazkov (Google)

Comment 3 2010-02-17 13:40:05 PST

Dumitru Daniliuc

Comment 4 2010-02-17 14:47:54 PST

Landed as r54910.

Note You need to log in before you can comment on or make changes to this bug.