Summary: | Introduce InspectorFrontendClient that would provide InspectorFrontend with an interface to the embedder | ||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yury Semikhatsky <yurys> | ||||||||||||||||||||||
Component: | Web Inspector (Deprecated) | Assignee: | Yury Semikhatsky <yurys> | ||||||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||||||
Severity: | Normal | CC: | dglazkov, jamey.hicks, pfeldman, timothy, webkit.review.bot | ||||||||||||||||||||||
Priority: | P2 | ||||||||||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||||||||||
Hardware: | All | ||||||||||||||||||||||||
OS: | All | ||||||||||||||||||||||||
Attachments: |
|
Description
Yury Semikhatsky
2010-02-17 06:52:23 PST
Design image from one of the previous commits: https://bugs.webkit.org/attachment.cgi?id=43869 Created attachment 49726 [details]
patch for Mac platform
Please take a look at the patch. It works only on Mac but it should reflect general approach. I'm working on support for other platforms.
Comment on attachment 49726 [details]
patch for Mac platform
Putting r? for xenon to get this wip patch in his review queue.
Attachment 49726 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/inspector/InspectorFrontendClientLocal.cpp:39: Alphabetical sorting problem. [build/include_order] [4]
WebCore/inspector/InspectorFrontendClientLocal.cpp:50: Alphabetical sorting problem. [build/include_order] [4]
WebCore/inspector/ConsoleMessage.h:41: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 3 in 25 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Attachment 49726 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/320196 Created attachment 50424 [details]
patch
r=me. Could you try doing rebase? (bots could not apply the patch) Created attachment 50492 [details]
patch
Rebased previous patch.
Attachment 50492 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/inspector/InspectorFrontendClientLocal.cpp:39: Alphabetical sorting problem. [build/include_order] [4]
WebCore/inspector/InspectorFrontendClientLocal.cpp:50: Alphabetical sorting problem. [build/include_order] [4]
WARNING: File exempt from style guide. Skipping: "WebKit/qt/Api/qwebinspector.cpp"
WARNING: File exempt from style guide. Skipping: "WebKit/qt/Api/qwebpage.h"
WARNING: File exempt from style guide. Skipping: "WebKit/qt/Api/qwebinspector.h"
WebCore/inspector/ConsoleMessage.h:41: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 3 in 59 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 50493 [details]
patch
Fixed style errors.
Attachment 50493 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WARNING: File exempt from style guide. Skipping: "WebKit/qt/Api/qwebinspector.cpp"
WARNING: File exempt from style guide. Skipping: "WebKit/qt/Api/qwebpage.h"
WARNING: File exempt from style guide. Skipping: "WebKit/qt/Api/qwebinspector.h"
WebCore/inspector/ConsoleMessage.h:55: More than one command on the same line [whitespace/newline] [4]
Total errors found: 1 in 59 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 50494 [details]
patch
One more style fix.
Created attachment 50498 [details]
patch
Added new files to WebCore.vcproj
Created attachment 50594 [details]
patch
Fixed layout issue when inspector opens attached.
Created attachment 50777 [details]
patch
Inroduced InspectorController::disconnectFrontend method and inlined couple of others.
Created attachment 50778 [details]
patch
WebCore/ChangeLog merge conflict resolved.
Created attachment 50779 [details]
patch that I'm going to land
Added support for Efl platform.
Committing to http://svn.webkit.org/repository/webkit/trunk ... C WebCore/inspector/InspectorFrontendHost.idl => WebCore/inspector/InspectorFrontendClient.h C WebCore/inspector/front-end/InspectorFrontendHostStub.js => WebCore/inspector/InspectorFrontendClientLocal.h M WebCore/ChangeLog M WebCore/GNUmakefile.am M WebCore/WebCore.Inspector.exp M WebCore/WebCore.base.exp M WebCore/WebCore.gypi M WebCore/WebCore.order M WebCore/WebCore.pro M WebCore/WebCore.vcproj/WebCore.vcproj M WebCore/WebCore.xcodeproj/project.pbxproj M WebCore/inspector/ConsoleMessage.cpp M WebCore/inspector/ConsoleMessage.h M WebCore/inspector/InspectorClient.h M WebCore/inspector/InspectorController.cpp M WebCore/inspector/InspectorController.h M WebCore/inspector/InspectorFrontend.cpp M WebCore/inspector/InspectorFrontend.h A WebCore/inspector/InspectorFrontendClientLocal.cpp M WebCore/inspector/InspectorFrontendHost.cpp M WebCore/inspector/InspectorFrontendHost.h M WebCore/inspector/InspectorFrontendHost.idl M WebCore/inspector/InspectorResource.cpp M WebCore/inspector/InspectorResource.h M WebCore/inspector/front-end/InspectorFrontendHostStub.js M WebCore/inspector/front-end/inspector.js M WebCore/loader/EmptyClients.h M WebCore/loader/FrameLoader.cpp M WebCore/page/Page.cpp M WebCore/page/Page.h M WebCore/platform/ContextMenu.cpp M WebKit/ChangeLog M WebKit/chromium/ChangeLog M WebKit/chromium/src/InspectorClientImpl.cpp M WebKit/chromium/src/InspectorClientImpl.h M WebKit/chromium/src/WebDevToolsAgentImpl.cpp M WebKit/chromium/src/WebDevToolsAgentImpl.h M WebKit/chromium/src/WebDevToolsFrontendImpl.cpp M WebKit/chromium/src/WebDevToolsFrontendImpl.h M WebKit/chromium/src/js/InjectDispatch.js M WebKit/efl/WebCoreSupport/InspectorClientEfl.cpp M WebKit/efl/WebCoreSupport/InspectorClientEfl.h M WebKit/gtk/ChangeLog M WebKit/gtk/WebCoreSupport/InspectorClientGtk.cpp M WebKit/gtk/WebCoreSupport/InspectorClientGtk.h M WebKit/haiku/ChangeLog M WebKit/haiku/WebCoreSupport/InspectorClientHaiku.cpp M WebKit/haiku/WebCoreSupport/InspectorClientHaiku.h M WebKit/mac/ChangeLog M WebKit/mac/WebCoreSupport/WebInspectorClient.h M WebKit/mac/WebCoreSupport/WebInspectorClient.mm M WebKit/mac/WebInspector/WebInspector.mm M WebKit/qt/Api/qwebinspector.cpp M WebKit/qt/Api/qwebinspector.h M WebKit/qt/Api/qwebpage.h M WebKit/qt/ChangeLog M WebKit/qt/WebCoreSupport/InspectorClientQt.cpp M WebKit/qt/WebCoreSupport/InspectorClientQt.h M WebKit/win/ChangeLog M WebKit/win/WebCoreSupport/WebInspectorClient.cpp M WebKit/win/WebCoreSupport/WebInspectorClient.h M WebKit/win/WebInspector.cpp M WebKit/wx/ChangeLog M WebKit/wx/WebKitSupport/InspectorClientWx.cpp M WebKit/wx/WebKitSupport/InspectorClientWx.h Committed r56051 |