Summary: | Can't cross-compile Qt/ARM anymore since r54616 (PluginViewNone.cpp vs. PluginView.cpp) | ||
---|---|---|---|
Product: | WebKit | Reporter: | Mirko Scavazzin <mscavazzin> |
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED DUPLICATE | ||
Severity: | Blocker | CC: | jhoneycutt, jturcotte |
Priority: | P2 | Keywords: | Qt |
Version: | 528+ (Nightly build) | ||
Hardware: | Other | ||
OS: | Linux |
Description
Mirko Scavazzin
2010-02-16 23:39:40 PST
I suggest to change PluginView::keepAlive definition in PluginView.cpp within ENABLE(NETSCAPE_PLUGIN_API) like this below (it works for me) : #if ENABLE(NETSCAPE_PLUGIN_API) void PluginView::keepAlive(NPP instance) { PluginView* view = instanceMap().get(instance); if (!view) return; view->keepAlive(); } #endif Please follow the QtWebKit bug reporting guidelines when reporting bugs. See http://trac.webkit.org/wiki/QtWebKitBugs Specifically: - The 'QtWebKit' component should only be used for bugs/features in the public QtWebKit API layer, not to signify that the bug is specific to the Qt port of WebKit http://trac.webkit.org/wiki/QtWebKitBugs#Component - Add the keyword 'Qt' to signal that it's a Qt-related bug http://trac.webkit.org/wiki/QtWebKitBugs#Keywords (In reply to comment #1) > I suggest to change PluginView::keepAlive definition in PluginView.cpp within > ENABLE(NETSCAPE_PLUGIN_API) like this below (it works for me) : > > #if ENABLE(NETSCAPE_PLUGIN_API) > void PluginView::keepAlive(NPP instance) > { > PluginView* view = instanceMap().get(instance); > if (!view) > return; > > view->keepAlive(); > } > #endif This change seems to be in trunk already. Please reopen if still valid. I get still the same problems. into PluginView.cpp please change from this : ----------------------------------------------------------------------------------------------- #if ENABLE(NETSCAPE_PLUGIN_API) void PluginView::keepAlive(NPP instance) { PluginView* view = instanceMap().get(instance); if (!view) return; view->keepAlive(); } #endif NPError PluginView::getValueStatic(NPNVariable variable, void* value) { LOG(Plugins, "PluginView::getValueStatic(%s)", prettyNameForNPNVariable(variable).data()); NPError result; if (platformGetValueStatic(variable, value, &result)) return result; return NPERR_GENERIC_ERROR; } ----------------------------------------------------------------------------------------------- to this: ----------------------------------------------------------------------------------------------- #if ENABLE(NETSCAPE_PLUGIN_API) void PluginView::keepAlive(NPP instance) { PluginView* view = instanceMap().get(instance); if (!view) return; view->keepAlive(); } NPError PluginView::getValueStatic(NPNVariable variable, void* value) { LOG(Plugins, "PluginView::getValueStatic(%s)", prettyNameForNPNVariable(variable).data()); NPError result; if (platformGetValueStatic(variable, value, &result)) return result; return NPERR_GENERIC_ERROR; } #endif ----------------------------------------------------------------------------------------------- and into PluginViewNone.cpp please change from this : ----------------------------------------------------------------------------------------------- #if ENABLE(NETSCAPE_PLUGIN_API) void PluginView::keepAlive(NPP) { } #endif void PluginView::privateBrowsingStateChanged(bool) { } void PluginView::setJavaScriptPaused(bool) { } ----------------------------------------------------------------------------------------------- to this: ----------------------------------------------------------------------------------------------- #if ENABLE(NETSCAPE_PLUGIN_API) void PluginView::keepAlive(NPP) { } void PluginView::privateBrowsingStateChanged(bool) { } void PluginView::setJavaScriptPaused(bool) { } #endif ----------------------------------------------------------------------------------------------- I get still the same problems. into PluginView.cpp please change from this : ----------------------------------------------------------------------------------------------- #if ENABLE(NETSCAPE_PLUGIN_API) void PluginView::keepAlive(NPP instance) { PluginView* view = instanceMap().get(instance); if (!view) return; view->keepAlive(); } #endif NPError PluginView::getValueStatic(NPNVariable variable, void* value) { LOG(Plugins, "PluginView::getValueStatic(%s)", prettyNameForNPNVariable(variable).data()); NPError result; if (platformGetValueStatic(variable, value, &result)) return result; return NPERR_GENERIC_ERROR; } ----------------------------------------------------------------------------------------------- to this: ----------------------------------------------------------------------------------------------- #if ENABLE(NETSCAPE_PLUGIN_API) void PluginView::keepAlive(NPP instance) { PluginView* view = instanceMap().get(instance); if (!view) return; view->keepAlive(); } NPError PluginView::getValueStatic(NPNVariable variable, void* value) { LOG(Plugins, "PluginView::getValueStatic(%s)", prettyNameForNPNVariable(variable).data()); NPError result; if (platformGetValueStatic(variable, value, &result)) return result; return NPERR_GENERIC_ERROR; } #endif ----------------------------------------------------------------------------------------------- and into PluginViewNone.cpp please change from this : ----------------------------------------------------------------------------------------------- #if ENABLE(NETSCAPE_PLUGIN_API) void PluginView::keepAlive(NPP) { } #endif void PluginView::privateBrowsingStateChanged(bool) { } void PluginView::setJavaScriptPaused(bool) { } ----------------------------------------------------------------------------------------------- to this: ----------------------------------------------------------------------------------------------- #if ENABLE(NETSCAPE_PLUGIN_API) void PluginView::keepAlive(NPP) { } void PluginView::privateBrowsingStateChanged(bool) { } void PluginView::setJavaScriptPaused(bool) { } #endif ----------------------------------------------------------------------------------------------- |