Bug 35006

Summary: fast/dom/global-constructors.html is failing based on previous tests
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED WORKSFORME    
Severity: Normal CC: ap, dpranke, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 34984    
Attachments:
Description Flags
Patch none

Eric Seidel (no email)
Reported 2010-02-16 15:58:38 PST
fast/dom/global-constructors.html is failing based on previous tests This is when run via run-chromium-webkit-tests (which runs tests in parallel, and thus out of order). -FAIL: window.CSSValue.prototype.isPrototypeOf(cssPrimitiveValue) should be true but instead is false -FAIL: window.CSSPrimitiveValue.prototype.isPrototypeOf(cssPrimitiveValue) should be true but instead is false +PASS: window.CSSValue.prototype.isPrototypeOf(cssPrimitiveValue) should be true and is. +PASS: window.CSSPrimitiveValue.prototype.isPrototypeOf(cssPrimitiveValue) should be true and is.
Attachments
Patch (1.35 KB, patch)
2010-04-01 22:18 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2010-02-25 16:54:28 PST
run-chromium-webkit-tests is now called new-run-webkit-tests.
Eric Seidel (no email)
Comment 2 2010-04-01 21:53:56 PDT
Bug 37007 is another test failing for similar reasons.
Eric Seidel (no email)
Comment 3 2010-04-01 21:57:14 PDT
This failure would be caused by there being some toJS() call which is wrapping a CSSPrimitiveValue which is not passing the right globalObject() (or any global object). Finding out which is causing the failure could be difficult, however fixing all of such possible bugs should be straightforward by removing the two-argument toJS calls and making sure that ll of those callsites are replaced by 3-argument toJS calls passing a proper globalObject().
Eric Seidel (no email)
Comment 4 2010-04-01 22:18:59 PDT
Created attachment 52377 [details] Patch
Eric Seidel (no email)
Comment 5 2010-04-01 22:22:34 PDT
Committed r56967: <http://trac.webkit.org/changeset/56967>
WebKit Review Bot
Comment 6 2010-04-01 22:57:05 PDT
http://trac.webkit.org/changeset/56967 might have broken Chromium Win Release
Eric Seidel (no email)
Comment 7 2010-04-01 22:59:12 PDT
No, that was just the Chroimum builder being unreliable and disconnecting. :(
Dirk Pranke
Comment 8 2011-04-06 19:42:05 PDT
If this is even still failing, I don't think it should block bug 34984. I plan on verifying that it works now, but if it doesn't, I plan to clear the blocking flag on Mon 4/11. If you disagree, now would be a good time to speak up :).
Dirk Pranke
Comment 9 2011-04-12 18:34:49 PDT
This test no longer appears to be failing. Closing as WORKSFORME.
Note You need to log in before you can comment on or make changes to this bug.