Bug 34975

Summary: [Qt] Correct build problems while building QtWebKit inside Qt.
Product: WebKit Reporter: Jocelyn Turcotte <jturcotte>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Enhancement CC: laszlo.gombos
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch v2 laszlo.gombos: review+

Jocelyn Turcotte
Reported 2010-02-16 04:13:11 PST
Building QtWebKit inside Qt's src/3rdparty had some issues
Attachments
Patch (1.72 KB, patch)
2010-02-16 05:05 PST, Jocelyn Turcotte 		no flags
DetailsFormatted DiffDiff
Patch v2 (1.70 KB, patch)
2010-02-17 01:44 PST, Jocelyn Turcotte 		laszlo.gombos: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jocelyn Turcotte
Comment 1 2010-02-16 05:05:25 PST
Created attachment 48806 [details] Patch Patch that corrects the problem.
Laszlo Gombos
Comment 2 2010-02-16 16:08:24 PST
Can we replace + !CONFIG(QTDIR_build): TARGET = $$qtLibraryTarget($$TARGET) with + TARGET = $$qtLibraryTarget($$TARGET) These rules are already complex enough, let's try to keep them as simple as possible.
Jocelyn Turcotte
Comment 3 2010-02-17 01:44:15 PST
Created attachment 48869 [details] Patch v2 (In reply to comment #2) Thanks, I missed that one, here is the new patch
Laszlo Gombos
Comment 4 2010-02-17 14:38:32 PST
Comment on attachment 48869 [details] Patch v2 Looks good to me, r+. It would be better to assign value to VERSION at same location. Perhaps you can make that change during landing just by moving some code around. Something like this: CONFIG(QTDIR_build) { include($$QT_SOURCE_TREE/src/qbase.pri) # Qt will set the version for us when building in Qt's tree VERSION=$${QT_MAJOR_VERSION}.$${QT_MINOR_VERSION}.$${QT_PATCH_VERSION} } else: VERSION = 4.7.0
Jocelyn Turcotte
Comment 5 2010-02-23 01:59:10 PST
Landed in r55133. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.