Bug 34974

Summary: Leak of ScheduledAction during layout tests
Product: WebKit Reporter: Mark Rowe (bdash) <mrowe>
Component: WebCore Misc.Assignee: Mark Rowe (bdash) <mrowe>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.6   
URL: http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r54814%20(4240)/DumpRenderTree2-leaks.txt
Attachments:
Description Flags
Patch v1 ap: review+

Description Mark Rowe (bdash) 2010-02-16 04:00:25 PST 
<http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r54814%20(4240)/DumpRenderTree2-leaks.txt> shows two instances of ScheduledAction being leaked during the layout tests.
Comment 1 Mark Rowe (bdash) 2010-02-16 04:13:02 PST 
Created attachment 48804 [details]
Patch v1
Comment 2 WebKit Review Bot 2010-02-16 04:17:50 PST 
Attachment 48804 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/bindings/js/ScheduledAction.h:28:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Alexey Proskuryakov 2010-02-16 13:13:25 PST 
Comment on attachment 48804 [details]
Patch v1

r=me, nice!

Style bot complained correctly.
Comment 4 Mark Rowe (bdash) 2010-02-16 14:54:04 PST 
Fixed in r54835.