Bug 34964

Summary: Leaks tool reports false memory leaks due to Rope implementation.
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: JavaScriptCoreAssignee: Gavin Barraclough <barraclough>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
The patch oliver: review+

Gavin Barraclough
Reported 2010-02-15 15:54:31 PST
A rope is a recursive data structure where each node in the rope holds a set of pointers, each of which may reference either a string (in UStringImpl form) or another rope node. A low bit in each pointer is used to distinguish between rope & string elements, in a fashion similar to the recently-removed PtrAndFlags class (see https://bugs.webkit.org/show_bug.cgi?id=33731 ). Again, this causes a problem for Leaks – refactor to remove the magic pointer mangling.
Attachments
The patch (36.71 KB, patch)
2010-02-16 15:23 PST, Gavin Barraclough 		oliver: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2010-02-16 15:23:31 PST
Created attachment 48841 [details] The patch No performance impact.
WebKit Review Bot
Comment 2 2010-02-16 15:26:28 PST
Attachment 48841 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 JavaScriptCore/runtime/UStringImpl.h:187: More than one command on the same line [whitespace/newline] [4] JavaScriptCore/runtime/UStringImpl.h:187: More than one command on the same line in if [whitespace/parens] [4] JavaScriptCore/runtime/UStringImpl.h:328: More than one command on the same line [whitespace/newline] [4] JavaScriptCore/runtime/UStringImpl.h:328: More than one command on the same line in if [whitespace/parens] [4] Total errors found: 4 If any of these errors are false positives, please file a bug against check-webkit-style.
Oliver Hunt
Comment 3 2010-02-16 15:26:46 PST
Comment on attachment 48841 [details] The patch r=me
Gavin Barraclough
Comment 4 2010-02-16 16:02:40 PST
Fixed in r54843.
Note You need to log in before you can comment on or make changes to this bug.