Summary: | Leaks tool reports false memory leaks due to Rope implementation. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gavin Barraclough <barraclough> | ||||
Component: | JavaScriptCore | Assignee: | Gavin Barraclough <barraclough> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Gavin Barraclough
2010-02-15 15:54:31 PST
Created attachment 48841 [details]
The patch
No performance impact.
Attachment 48841 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
JavaScriptCore/runtime/UStringImpl.h:187: More than one command on the same line [whitespace/newline] [4]
JavaScriptCore/runtime/UStringImpl.h:187: More than one command on the same line in if [whitespace/parens] [4]
JavaScriptCore/runtime/UStringImpl.h:328: More than one command on the same line [whitespace/newline] [4]
JavaScriptCore/runtime/UStringImpl.h:328: More than one command on the same line in if [whitespace/parens] [4]
Total errors found: 4
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 48841 [details]
The patch
r=me
|