Bug 34918

Summary: [GTK][Qt] Fails glyph reordering test fast/text/glyph-reordering.html
Product: WebKit Reporter: Gustavo Noronha (kov) <gustavo>
Component: TextAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, mitz, ossy, vestbo
Priority: P2 Keywords: Gtk, Qt
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
test in GTK+
none
Make the test less dependent on the complex text implementation none

Gustavo Noronha (kov)
Reported 2010-02-13 06:02:22 PST
Test output: This tests text selection in complex scripts where glyph reordering occurs. हिनà¥à¤¦à¥€ ि‌हनà¥à¤¦à¥€ FAIL: width was 116 instead of 174
Attachments
test in GTK+ (24.24 KB, image/png)
2010-02-15 17:56 PST, Gustavo Noronha (kov) 		no flags
Details
Make the test less dependent on the complex text implementation (2.93 KB, patch)
2010-02-16 08:09 PST, mitz 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2010-02-13 07:40:57 PST
This test fails on Qt port too, so I it was skipped by http://trac.webkit.org/changeset/54753 . output: This tests text selection in complex scripts where glyph reordering occurs. हिन्दी ि‌हन्दी FAIL: width was 96 instead of 192
mitz
Comment 2 2010-02-13 10:16:27 PST
Interesting. If you open the test in a browser, do the two lines of Devanagari text appear identical?
Csaba Osztrogonác
Comment 3 2010-02-13 12:55:49 PST
(In reply to comment #2) > Interesting. If you open the test in a browser, do the two lines of Devanagari > text appear identical? Unfortunately I saw only 6 and 8 black squares in QtLauncher. :( Tor Arne, it seems that we haven't Devanagari fonts. Why not?
Gustavo Noronha (kov)
Comment 4 2010-02-15 17:56:31 PST
Created attachment 48783 [details] test in GTK+ This is what I get in the GTK+ port
mitz
Comment 5 2010-02-16 07:27:49 PST
(In reply to comment #4) > Created an attachment (id=48783) [details] > test in GTK+ > > This is what I get in the GTK+ port I am going to try to make the test less dependent on other glyphs and the behavior of the complex text implementation.
mitz
Comment 6 2010-02-16 08:09:44 PST
Created attachment 48815 [details] Make the test less dependent on the complex text implementation Is this better?
Csaba Osztrogonác
Comment 7 2010-02-16 16:54:36 PST
(In reply to comment #6) > Created an attachment (id=48815) [details] > Make the test less dependent on the complex text implementation > > Is this better? I tested your patch on Qt buildbot and the test passes. Thx.
Eric Seidel (no email)
Comment 8 2010-02-17 16:22:59 PST
Comment on attachment 48815 [details] Make the test less dependent on the complex text implementation Based on the above comments from Qt, this looks good.
mitz
Comment 9 2010-02-17 16:29:06 PST
Landed in r54912. Didn’t unskip the tests though. Leaving it up to the reporter to do, verify and close the bug.
Csaba Osztrogonác
Comment 10 2010-02-17 23:42:55 PST
(In reply to comment #9) > Landed in r54912. Didn’t unskip the tests though. Leaving it up to the reporter > to do, verify and close the bug. Unskipped for Qt port by http://trac.webkit.org/changeset/54936 .
Gustavo Noronha (kov)
Comment 11 2010-02-18 10:59:17 PST
And for GTK+ in r54975. Thanks!
Note You need to log in before you can comment on or make changes to this bug.