Bug 3487

Summary: WebKit no longer builds after configuration supporting build changes
Product: WebKit Reporter: Michael Gaiman <mgaiman>
Component: New BugsAssignee: Darin Adler <darin>
Status: VERIFIED FIXED    
Severity: Normal    
Priority: P2    
Version: 412   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
Patch to default to Deployment when Configuration file isn't found
none
newline and configuration fixes
none
Follow-up darin: review+

Michael Gaiman
Reported 2005-06-12 17:52:32 PDT
Changes made to the build tools to support file-based configuration have broken the build process when that file is not found. Instead, the build should default to Deployment.
Attachments
Patch to default to Deployment when Configuration file isn't found (705 bytes, patch)
2005-06-12 17:53 PDT, Michael Gaiman 		no flags
DetailsFormatted DiffDiff
newline and configuration fixes (1.23 KB, patch)
2005-06-12 19:14 PDT, Michael Gaiman 		no flags
DetailsFormatted DiffDiff
Follow-up (4.32 KB, patch)
2005-06-12 20:33 PDT, Stuart Morgan 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Michael Gaiman
Comment 1 2005-06-12 17:53:22 PDT
Created attachment 2279 [details] Patch to default to Deployment when Configuration file isn't found
Michael Gaiman
Comment 2 2005-06-12 19:14:51 PDT
Created attachment 2281 [details] newline and configuration fixes In addition to the build failing if the Configuration file is not found, the current build script creates a new directory with a newline at the end if the build directory has not been set through Xcode. This patch fixes both problems.
Stuart Morgan
Comment 3 2005-06-12 20:33:47 PDT
Created attachment 2284 [details] Follow-up This is a follow-up fix that won't throw an error for attempting to read a filedescriptor that isn't open. It also converts use of `pwd` to Cwd's getcwd().
Joost de Valk (AlthA)
Comment 4 2005-07-03 07:58:20 PDT
Reporter, could you verify that this one is fixed?
Michael Gaiman
Comment 5 2005-07-03 08:06:42 PDT
Yes, it works as it should.
Note You need to log in before you can comment on or make changes to this bug.