Summary: | [gtk] WebKitDownload's currentSize property is guint, should be guint64 | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Diego Escalante Urrelo <diegoe> | ||||||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | commit-queue, eric, gustavo | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | PC | ||||||||||||
OS: | Linux | ||||||||||||
Bug Depends on: | 34898 | ||||||||||||
Bug Blocks: | |||||||||||||
Attachments: |
|
Description
Diego Escalante Urrelo
2010-02-10 21:06:27 PST
I can get this tested. Perhaps we should use goffset, though? Comment on attachment 48546 [details]
Quick *blind* fix
Your patch works. You get a warning on line 758, though, which you should fix before we land this (because Soup behaves correctly, and handles us a goffset instead). I wonder if we could move all our file size usage in WebKitDownload to goffset to be consistent/correct. I don't know why I didn't do that in the first place =(.
Created attachment 48578 [details] 2010-02-11 Diego Escalante Urrelo <descalante@igalia.com> Reviewed by NOBODY (OOPS!). [gtk] WebKitDownload's currentSize property is guint, should be guint64 https://bugs.webkit.org/show_bug.cgi?id=34829 Actually use a guint64 for current-size property in WebKitDownload, we were using a guint which is likely the cause for wrong sizes for files over 4 Gb. * webkit/webkitdownload.cpp: Created attachment 48585 [details] 2010-02-11 Diego Escalante Urrelo <descalante@igalia.com> Reviewed by NOBODY (OOPS!). [gtk] WebKitDownload's currentSize property is guint, should be guint64 https://bugs.webkit.org/show_bug.cgi?id=34829 Actually use a guint64 for current-size property in WebKitDownload, we were using a guint which is likely the cause for wrong sizes for files over 4 Gb. * webkit/webkitdownload.cpp: Created attachment 48586 [details] 2010-02-11 Diego Escalante Urrelo <descalante@igalia.com> Reviewed by NOBODY (OOPS!). [gtk] WebKitDownload's currentSize property is guint, should be guint64 https://bugs.webkit.org/show_bug.cgi?id=34829 Actually use a guint64 for current-size property in WebKitDownload, we were using a guint which is likely the cause for wrong sizes for files over 4 Gb. * webkit/webkitdownload.cpp: Comment on attachment 48586 [details] 2010-02-11 Diego Escalante Urrelo <descalante@igalia.com> Looks good, thanks! Comment on attachment 48586 [details] 2010-02-11 Diego Escalante Urrelo <descalante@igalia.com> Rejecting patch 48586 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 12150 test cases. websocket/tests/bufferedAmount-after-close.html -> crashed Exiting early after 1 failures. 12118 tests run. 497.21s total testing time 12117 test cases (99%) succeeded 1 test case (<1%) crashed 7 test cases (<1%) had stderr output Full output: http://webkit-commit-queue.appspot.com/results/258584 Comment on attachment 48586 [details] 2010-02-11 Diego Escalante Urrelo <descalante@igalia.com> The failure doesn't seem to be related. Comment on attachment 48586 [details] 2010-02-11 Diego Escalante Urrelo <descalante@igalia.com> Clearing flags on attachment: 48586 Committed r54762: <http://trac.webkit.org/changeset/54762> All reviewed patches have been landed. Closing bug. Crash was bug 34898. |