Summary: | webkit-build-directory misuses terms | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, dpranke, mrowe | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Bug Depends on: | 34898 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Eric Seidel (no email)
2010-02-10 17:42:26 PST
The current behavior seems to be: webkit-build-directory -> WebKitBuild/Release webkit-build-directory --debug -> WebKitBuild/Debug webkit-build-directory --base -> WebKitBuild I’m basically suggesting that we do the following: webkit-build-directory -> error, need to specify which directory you want. webkit-build-directory --configuration-build-directory -> WebKitBuild/Release webkit-build-directory --configuration-build-directory --debug -> WebKitBuild/Debug webkit-build-directory --base-build-directory -> WebKitBuild I don’t think that it is intuitive for a script named webkit-build-directory to default to giving you the per-configuration build directory. Making it explicit which directory is being requested is much clearer. The option names I suggested may be a little verbose. I just picked the most literal names possible. Created attachment 48538 [details]
Patch
Comment on attachment 48538 [details]
Patch
Does this look good to you Mark?
Comment on attachment 48538 [details] Patch Rejecting patch 48538 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 12157 test cases. websocket/tests/bufferedAmount-after-close.html -> crashed Exiting early after 1 failures. 12124 tests run. 500.30s total testing time 12123 test cases (99%) succeeded 1 test case (<1%) crashed 7 test cases (<1%) had stderr output Full output: http://webkit-commit-queue.appspot.com/results/261095 Comment on attachment 48538 [details] Patch Bug 34898. Comment on attachment 48538 [details] Patch Clearing flags on attachment: 48538 Committed r54759: <http://trac.webkit.org/changeset/54759> All reviewed patches have been landed. Closing bug. |