Bug 34794

Summary: [BREWMP] Port PlatformKeyboardEvent
Product: WebKit Reporter: Kwang Yul Seo <skyul>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Bug Depends on:    
Bug Blocks: 33564    
Attachments:
Description Flags
Patch none

Kwang Yul Seo
Reported 2010-02-10 04:16:02 PST
Port PlatformKeyboardEvent to BREWMP.
Attachments
Patch (7.26 KB, patch)
2010-02-10 04:54 PST, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kwang Yul Seo
Comment 1 2010-02-10 04:54:35 PST
Created attachment 48488 [details] Patch
Eric Seidel (no email)
Comment 2 2010-02-10 13:17:58 PST
Comment on attachment 48488 [details] Patch I'm not sure this makes sense: #if PLATFORM(BREWMP) 67 typedef unsigned short uint16; 68 typedef unsigned long int uint32; 69 #define AEEEvent uint16 70 #endif Seems we should include whatever header defines AEEvent instead. Is AEEvent really a #define? Or is it actually a typedef?
Kwang Yul Seo
Comment 3 2010-02-10 19:04:32 PST
(In reply to comment #2) > (From update of attachment 48488 [details]) > I'm not sure this makes sense: > #if PLATFORM(BREWMP) > 67 typedef unsigned short uint16; > 68 typedef unsigned long int uint32; > 69 #define AEEEvent uint16 > 70 #endif > > Seems we should include whatever header defines AEEvent instead. Is AEEvent > really a #define? Or is it actually a typedef? AEEvent is actually defined to uint16 in AEEEvent.h. #define AEEEvent uint16
Eric Seidel (no email)
Comment 4 2010-02-17 15:58:57 PST
Comment on attachment 48488 [details] Patch OK.
WebKit Commit Bot
Comment 5 2010-02-17 22:12:13 PST
Comment on attachment 48488 [details] Patch Clearing flags on attachment: 48488 Committed r54930: <http://trac.webkit.org/changeset/54930>
WebKit Commit Bot
Comment 6 2010-02-17 22:12:16 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.