Bug 34794

Summary: [BREWMP] Port PlatformKeyboardEvent
Product: WebKit Reporter: Kwang Yul Seo <skyul>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Bug Depends on:    
Bug Blocks: 33564    
Attachments:
Description Flags
Patch none

Description Kwang Yul Seo 2010-02-10 04:16:02 PST 
Port PlatformKeyboardEvent to BREWMP.
Comment 1 Kwang Yul Seo 2010-02-10 04:54:35 PST 
Created attachment 48488 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-02-10 13:17:58 PST 
Comment on attachment 48488 [details]
Patch

I'm not sure this makes sense:
#if PLATFORM(BREWMP)
 67 typedef unsigned short    uint16;
 68 typedef unsigned long int uint32;
 69 #define AEEEvent uint16
 70 #endif

Seems we should include whatever header defines AEEvent instead.  Is AEEvent really a #define?  Or is it actually a typedef?
Comment 3 Kwang Yul Seo 2010-02-10 19:04:32 PST 
(In reply to comment #2)
> (From update of attachment 48488 [details])
> I'm not sure this makes sense:
> #if PLATFORM(BREWMP)
>  67 typedef unsigned short    uint16;
>  68 typedef unsigned long int uint32;
>  69 #define AEEEvent uint16
>  70 #endif
> 
> Seems we should include whatever header defines AEEvent instead.  Is AEEvent
> really a #define?  Or is it actually a typedef?

AEEvent is actually defined to uint16 in AEEEvent.h.

#define AEEEvent  uint16
Comment 4 Eric Seidel (no email) 2010-02-17 15:58:57 PST 
Comment on attachment 48488 [details]
Patch

OK.
Comment 5 WebKit Commit Bot 2010-02-17 22:12:13 PST 
Comment on attachment 48488 [details]
Patch

Clearing flags on attachment: 48488

Committed r54930: <http://trac.webkit.org/changeset/54930>
Comment 6 WebKit Commit Bot 2010-02-17 22:12:16 PST 
All reviewed patches have been landed.  Closing bug.