Summary: | New assertion in UStringImpl::create() is overzealous | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | John Sullivan <sullivan> | ||||
Component: | JavaScriptCore | Assignee: | John Sullivan <sullivan> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | barraclough, ggaren | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
URL: | http://www.salon.com/technology/the_gigaom_network/gadget_gurus/2010/02/09/will_notion_inks_adam_be_the_ipad_for_geeks | ||||||
Attachments: |
|
Description
John Sullivan
2010-02-09 11:57:31 PST
The assertion is in UStringImpl::adopt(), not UStringImpl::create(). I'll have a patch in a moment. Created attachment 48435 [details]
Patch to only assert that vector.data() is non-empty if vector.size() is non-zero.
Comment on attachment 48435 [details]
Patch to only assert that vector.data() is non-empty if vector.size() is non-zero.
ok
CC'ing Gavin, since he introduced the ASSERT. |