Bug 34744

Summary: [Chromium] Upstream JavaScript part of DevTools WebKit API implementation
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: WebKit APIAssignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, pfeldman
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch pfeldman: review+

Yury Semikhatsky
Reported 2010-02-09 03:04:25 PST
The JavaScript files living in chromium repository at webkit/glue/devtools/js/ should move to WebKit.
Attachments
patch (232.36 KB, patch)
2010-02-09 03:37 PST, Yury Semikhatsky 		pfeldman: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2010-02-09 03:37:58 PST
Created attachment 48401 [details] patch
Pavel Feldman
Comment 2 2010-02-09 04:54:54 PST
Comment on attachment 48401 [details] patch Please shorten ChangeLog and limit it to the added files. No need to scare people. Could you also leave FIXME in all the files requesting that private members are renamed to leading underscore?
Yury Semikhatsky
Comment 3 2010-02-09 07:15:38 PST
(In reply to comment #2) > (From update of attachment 48401 [details]) > Please shorten ChangeLog and limit it to the added files. No need to scare > people. > > Could you also leave FIXME in all the files requesting that private members are > renamed to leading underscore? Done. Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKit/chromium/ChangeLog A WebKit/chromium/WebKit.gypi A WebKit/chromium/src/js/DebuggerAgent.js A WebKit/chromium/src/js/DevTools.js A WebKit/chromium/src/js/DevToolsHostStub.js A WebKit/chromium/src/js/HeapProfilerPanel.js A WebKit/chromium/src/js/InjectDispatch.js A WebKit/chromium/src/js/InspectorControllerImpl.js A WebKit/chromium/src/js/ProfilerAgent.js A WebKit/chromium/src/js/ProfilerProcessor.js A WebKit/chromium/src/js/Tests.js Committed r54547
Note You need to log in before you can comment on or make changes to this bug.