MathML Support for mfrac

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Alex Milowski]

Created attachment 48393 [details]
The patch to add support for mfrac.

This patch adds support for non-beveled fractions for the MathML mfrac element.  There is basic support for the fraction line thickness.

[Alex Milowski]

Created attachment 49951 [details]
Updated the patch to the latest trunk and added other changes suggested 

I also added some changes suggested by Sausset François.

[Kenneth Rohde Christiansen]

Comment on attachment 49951 [details]
Updated the patch to the latest trunk and added other changes suggested 


> +    if (lastChild())
> +        if (lastChild()->isRenderBlock()) {
> +            RenderBlock* denominator = toRenderBlock(lastChild());
> +            int previousWidth = denominator->style()->borderTopWidth();
> +            int borderWidth = static_cast<int>(ceil(gFractionBarWidth * style()->fontSize()));
> +            denominator->style()->setBorderTopWidth(previousWidth * borderWidth);
> +        }
> +    
> +    if (previousSibling())
> +        if (previousSibling()->isRenderBlock()) {
> +            RenderBlock* sibling = toRenderBlock(previousSibling());
> +            verticalAlignCompute(sibling);
> +            RenderBlock::layout();
> +            return;
> +        }
> +    if (nextSibling())
> +        if (nextSibling()->isRenderBlock()) {
> +            RenderBlock* sibling = toRenderBlock(nextSibling());
> +            verticalAlignCompute(sibling);
> +        }
> +    

The above is against our coding style. An if with contents (comments included) spanding more than one line should use {}

[Alex Milowski]

Created attachment 51291 [details]
Updated mfrac implementation with custom painting of fraction line

[Kenneth Rohde Christiansen]

Comment on attachment 51291 [details]
Updated mfrac implementation with custom painting of fraction line

Looks good!

[WebKit Commit Bot]

Comment on attachment 51291 [details]
Updated mfrac implementation with custom painting of fraction line

Clearing flags on attachment: 51291

Committed r56340: <http://trac.webkit.org/changeset/56340>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.