Bug 34698

Summary:

Restore ENABLE_RUBY flag so vendors can ship with Ruby disabled if they choose.

Product:

WebKit

Reporter:

Maciej Stachowiak <mjs>

Component:

New Bugs

Assignee:

Maciej Stachowiak <mjs>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bweinstein, eric, zwarich

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	zwarich: review+

Maciej Stachowiak

Reported 2010-02-08 00:45:45 PST

Restore ENABLE_RUBY flag so vendors can ship with Ruby disabled if they choose.

Attachments
Patch (23.13 KB, patch) 2010-02-08 00:48 PST, Maciej Stachowiak	zwarich: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Maciej Stachowiak

Comment 1 2010-02-08 00:48:01 PST

Created attachment 48325 [details] Patch

Cameron Zwarich (cpst)

Comment 2 2010-02-08 00:50:11 PST

Comment on attachment 48325 [details] Patch r=me

Eric Seidel (no email)

Comment 3 2010-02-08 11:21:39 PST

Attachment 48325 [details] was posted by a committer and has review+, assigning to Maciej Stachowiak for commit.

Maciej Stachowiak

Comment 4 2010-02-11 02:56:06 PST

Committed r54649: <http://trac.webkit.org/changeset/54649>

Eric Seidel (no email)

Comment 5 2010-02-11 03:24:16 PST

This broke the windows builds into a thousand pieces. :(

Eric Seidel (no email)

Comment 6 2010-02-11 03:25:05 PST

We really need a windows EWS bot to catch these sorts of failures.

Eric Seidel (no email)

Comment 7 2010-02-11 15:19:36 PST

This broke the windows build over 12 hours ago. I think we should roll this out.

Eric Seidel (no email)

Comment 8 2010-02-11 15:20:19 PST

Looks like Brian is attempting to fix as we speak.

Note You need to log in before you can comment on or make changes to this bug.