Bug 34682

Summary: [GTK] Implement FrameLoaderClient::hasWebView
Product: WebKit Reporter: Xan Lopez <xan.lopez>
Component: WebKitGTKAssignee: Xan Lopez <xan.lopez>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
haswebview.diff
xan.lopez: commit-queue-
haswebview.diff gustavo: review+, xan.lopez: commit-queue-

Xan Lopez
Reported 2010-02-06 13:21:53 PST
Used for sanity-check ASSERTS throughout the FrameLoader code.
Attachments
haswebview.diff (1.82 KB, patch)
2010-02-06 13:25 PST, Xan Lopez 		xan.lopez: commit-queue-
DetailsFormatted DiffDiff
haswebview.diff (1.82 KB, patch)
2010-02-06 13:35 PST, Xan Lopez 		gustavo: review+
xan.lopez: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Xan Lopez
Comment 1 2010-02-06 13:25:20 PST
Created attachment 48293 [details] haswebview.diff
WebKit Review Bot
Comment 2 2010-02-06 13:30:58 PST
Attachment 48293 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp:566: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 If any of these errors are false positives, please file a bug against check-webkit-style.
Xan Lopez
Comment 3 2010-02-06 13:35:16 PST
Created attachment 48294 [details] haswebview.diff Fixing the style issue pointed by the bot.
Gustavo Noronha (kov)
Comment 4 2010-02-08 10:29:42 PST
Comment on attachment 48294 [details] haswebview.diff r=me
Eric Seidel (no email)
Comment 5 2010-02-08 11:21:27 PST
Attachment 48294 [details] was posted by a committer and has review+, assigning to Xan Lopez for commit.
Xan Lopez
Comment 6 2010-02-09 00:52:02 PST
I landed this as r54508, closing.
Note You need to log in before you can comment on or make changes to this bug.