Bug 34669

Summary:

getUniformLocation should return null for invalid uniforms

Product:

WebKit

Reporter:

Kenneth Russell <kbr>

Component:

WebGL

Assignee:

Vangelis Kokkevis <vangelis>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cmarrin, commit-queue, oliver

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Proposed patch	none

Description Kenneth Russell 2010-02-05 17:27:49 PST

WebGLRenderingContext::getUniformLocation should return null for invalid uniforms. Currently it will return a WebGLUniformLocation object wrapping the number -1, which is poor behavior. As a corollary, the WebGL specification should be updated to state this behavior explicitly.

Comment 1 Vangelis Kokkevis 2010-03-03 18:41:26 PST

Created attachment 49977 [details]
Proposed patch

Comment 2 WebKit Commit Bot 2010-03-04 01:41:35 PST

Comment on attachment 49977 [details]
Proposed patch

Clearing flags on attachment: 49977

Committed r55514: <http://trac.webkit.org/changeset/55514>

Comment 3 WebKit Commit Bot 2010-03-04 01:41:39 PST

All reviewed patches have been landed.  Closing bug.

Comment 4 Vangelis Kokkevis 2010-03-04 14:24:55 PST

WebGL spec updated accordingly in rev 10594