Summary: | [V8] Use toV8() for wrapping objects in a WorkerContext | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nate Chapin <japhet> | ||||
Component: | WebCore Misc. | Assignee: | Nate Chapin <japhet> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | ||||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Nate Chapin
2010-02-05 13:09:50 PST
Created attachment 48254 [details]
patch
Perf tests are still running, but I think this change is ok.
Comment on attachment 48254 [details] patch This looks great! Except: > + // Get the WorkerContextExecutionProxy first. If we are in a WorkerContext and we try to call V8Proxy::retrieve(), > + // we crash trying to retrieve a DOMWindow. > + WorkerContextExecutionProxy* workerContextProxy = WorkerContextExecutionProxy::retrieve(); Are you sure this doesn't affect performance? (In reply to comment #2) > (From update of attachment 48254 [details]) > This looks great! Except: > > > + // Get the WorkerContextExecutionProxy first. If we are in a WorkerContext and we try to call V8Proxy::retrieve(), > > + // we crash trying to retrieve a DOMWindow. > > + WorkerContextExecutionProxy* workerContextProxy = WorkerContextExecutionProxy::retrieve(); > > Are you sure this doesn't affect performance? I ran the dromaeo tests locally and the results were comparable with and without the change. If there's anything else you'd like me to run, please let me know :) Comment on attachment 48254 [details]
patch
ok. I trust you'll monitor the perf bots.
|