Bug 34646

Summary:

Web Inspector: simplify cookies view, introduce DataGrid::autoSizeColumns.

Product:

WebKit

Reporter:

Pavel Feldman <pfeldman>

Component:

Web Inspector (Deprecated)

Assignee:

Pavel Feldman <pfeldman>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bweinstein, joepeck, rik, timothy

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed change.	none
[PATCH] Same with a minor fix for platforms with no raw cookie access.	timothy: review+

Pavel Feldman

Reported 2010-02-05 06:01:51 PST

I brushed up CookiesView a bit (fixed sorting to preserve selection, delete to preserve sorting, general code brush up). I noticed fair amount of copypaste logic related to the auto-sizing of columns in DataGrid and fixed that as well.

Attachments
[PATCH] Proposed change. (27.05 KB, patch) 2010-02-05 06:09 PST, Pavel Feldman	no flags	Details Formatted Diff Diff
[PATCH] Same with a minor fix for platforms with no raw cookie access. (27.38 KB, patch) 2010-02-05 06:53 PST, Pavel Feldman	timothy: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Pavel Feldman

Comment 1 2010-02-05 06:09:50 PST

Created attachment 48228 [details] [PATCH] Proposed change.

Pavel Feldman

Comment 2 2010-02-05 06:53:17 PST

Created attachment 48230 [details] [PATCH] Same with a minor fix for platforms with no raw cookie access.

Pavel Feldman

Comment 3 2010-02-05 11:30:30 PST

Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/CookieItemsView.js M WebCore/inspector/front-end/DOMStorageItemsView.js M WebCore/inspector/front-end/DataGrid.js M WebCore/inspector/front-end/DatabaseQueryView.js M WebCore/inspector/front-end/DatabaseTableView.js M WebCore/inspector/front-end/StoragePanel.js Committed r54436

Note You need to log in before you can comment on or make changes to this bug.