Bug 34638

Summary: Web Inspector: Continue with JAVASCRIPT_DEBUGGER enabling in chromium port
Product: WebKit Reporter: Mikhail Naganov <mnaganov>
Component: Web Inspector (Deprecated)Assignee: Mikhail Naganov <mnaganov>
Status: RESOLVED FIXED    
Severity: Normal CC: bweinstein, commit-queue, joepeck, keishi, pfeldman, pmuellr, rik, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
proposed patch none

Mikhail Naganov
Reported 2010-02-05 02:05:51 PST
Now it's time to enable JAVASCRIPT_DEBUGGER in features.gypi and remove "USE(V8)" in "#if ENABLE(JAVASCRIPT_DEBUGGER) || USE(V8)" clauses.
Attachments
proposed patch (3.51 KB, patch)
2010-02-05 02:10 PST, Mikhail Naganov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mikhail Naganov
Comment 1 2010-02-05 02:10:22 PST
Created attachment 48213 [details] proposed patch
WebKit Commit Bot
Comment 2 2010-02-05 03:36:19 PST
Comment on attachment 48213 [details] proposed patch Rejecting patch 48213 from commit-queue. mnaganov@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in WebKitTools/Scripts/webkitpy/committers.py by adding yourself to the file (no review needed). Due to bug 30084 the commit-queue will require a restart after your change. Please contact eseidel@chromium.org to request a commit-queue restart. After restart the commit-queue will correctly respect your committer rights.
WebKit Commit Bot
Comment 3 2010-02-05 04:05:45 PST
Comment on attachment 48213 [details] proposed patch Clearing flags on attachment: 48213 Committed r54417: <http://trac.webkit.org/changeset/54417>
WebKit Commit Bot
Comment 4 2010-02-05 04:05:52 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.