Bug 34620

Summary: Changing display type of parent of input on focus causes input field to not receive key events
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: enrica
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: OS X 10.5   
URL: http://www.facebook.com/
Attachments:
Description Flags
Reduction
none
Patch
none
Patch mitz: review+

Simon Fraser (smfr)
Reported 2010-02-04 15:17:26 PST
Created attachment 48174 [details] Reduction See attached testcase; if the focus handler on a text field changes the text field's parent display to inline-block, then the text field loses the ability to receive key events (but it retains focus). This affects the Facebook signup page.
Attachments
Reduction (572 bytes, text/html)
2010-02-04 15:17 PST, Simon Fraser (smfr) 		no flags
Details
Patch (4.96 KB, patch)
2010-02-04 18:38 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (8.88 KB, patch)
2010-02-04 20:29 PST, Simon Fraser (smfr) 		mitz: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2010-02-04 15:17:46 PST
<rdar://problem/7584572>
Simon Fraser (smfr)
Comment 2 2010-02-04 16:32:28 PST
The problem here is that VisibleSelection.start() keeps pointing to the old m_innerText of the RenderTextControlSingleLine, even after a new one gets created during layout.
Simon Fraser (smfr)
Comment 3 2010-02-04 18:38:22 PST
Created attachment 48190 [details] Patch
Simon Fraser (smfr)
Comment 4 2010-02-04 20:08:47 PST
Comment on attachment 48190 [details] Patch Mitz points out that Element::attach() goes to some length to avoid calling updateFocusAppearance() directly.
Simon Fraser (smfr)
Comment 5 2010-02-04 20:29:50 PST
Created attachment 48196 [details] Patch
Simon Fraser (smfr)
Comment 6 2010-02-05 11:50:47 PST
http://trac.webkit.org/changeset/54438
Note You need to log in before you can comment on or make changes to this bug.