| Summary: | Chromium Mac: Control-A shouldn't select all/Control-C shouldn't copy | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Avi Drissman <avi> | ||||||
| Component: | WebKit Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, levin | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | PC | ||||||||
| OS: | OS X 10.5 | ||||||||
| Attachments: |
|
||||||||
|
Description
Avi Drissman
2010-02-04 14:08:05 PST
Created attachment 48169 [details]
Patch to fix
Comment on attachment 48169 [details]
Patch to fix
Can't this be verifier with a (platform specific) layout test?
Also it looks like the you're changing more than the Control+A behavior (which seems fine), but the ChangeLog and bug only seem to refer to the Ctrl+a behavior.
r- due to lack of layout test.
The original bug was about control-A, but when I dug I found control-C too which worked (and shouldn't have) but people didn't notice like they did with control-A. Lemme crank out a test and get back to you. Created attachment 48369 [details]
Now with layout test
Comment on attachment 48369 [details] Now with layout test Clearing flags on attachment: 48369 Committed r54535: <http://trac.webkit.org/changeset/54535> All reviewed patches have been landed. Closing bug. |