Bug 34615

Summary: Chromium Mac: Control-A shouldn't select all/Control-C shouldn't copy
Product: WebKit Reporter: Avi Drissman <avi>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Severity: Normal CC: commit-queue, levin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Description Flags
Patch to fix
levin: review-
Now with layout test none

Description Avi Drissman 2010-02-04 14:08:05 PST
Patch to come.
Comment 1 Avi Drissman 2010-02-04 14:10:34 PST
Created attachment 48169 [details]
Patch to fix
Comment 2 David Levin 2010-02-04 17:44:28 PST
Comment on attachment 48169 [details]
Patch to fix

Can't this be verifier with a (platform specific) layout test?

Also it looks like the you're changing more than the Control+A behavior (which seems fine), but the ChangeLog and bug only seem to refer to the Ctrl+a behavior.

r- due to lack of layout test.
Comment 3 Avi Drissman 2010-02-05 07:06:08 PST
The original bug was about control-A, but when I dug I found control-C too which worked (and shouldn't have) but people didn't notice like they did with control-A.

Lemme crank out a test and get back to you.
Comment 4 Avi Drissman 2010-02-08 15:49:13 PST
Created attachment 48369 [details]
Now with layout test
Comment 5 WebKit Commit Bot 2010-02-09 00:52:12 PST
Comment on attachment 48369 [details]
Now with layout test

Clearing flags on attachment: 48369

Committed r54535: <http://trac.webkit.org/changeset/54535>
Comment 6 WebKit Commit Bot 2010-02-09 00:52:20 PST
All reviewed patches have been landed.  Closing bug.