Bug 34604

Summary:

check-webkit-style false positive for WebCore forwarding header

Product:

WebKit

Reporter:

Geoffrey Garen <ggaren>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, cjerdonek, eric, hamaji, levin

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch v1	none

Description Geoffrey Garen 2010-02-04 10:56:53 PST

See bug 33383.

WebCore forwarding headers have a special header guard style.

Comment 1 Eric Seidel (no email) 2010-02-04 11:00:44 PST

Thanks for the report!

Comment 2 David Levin 2010-02-04 11:19:35 PST

It looks like the rule here is if dir includes /([^/]*)/ForwardingHeaders/, then the header guard should be

$1_FWD_NormalHeaderGuard

Comment 3 Shinichiro Hamaji 2010-02-16 03:52:04 PST

It seems JavaScriptCore/ForwardingHeaders/**/*.h, WebKit/mac/ForwardingHeaders/**/*.h, and WebKitTools/DumpRenderTree/ForwardingHeaders/**/*.h don't contain #ifndef guards. Maybe we can just silence build/header_guard for ForwardingHeaders? I'm not sure if it's worth to implement the check of $1_FWD_ style header guard only for WebCore.

Comment 4 Shinichiro Hamaji 2010-02-23 22:49:43 PST

Created attachment 49360 [details]
Patch v1

Comment 5 Shinichiro Hamaji 2010-02-23 22:50:50 PST

> Patch v1

This patch just disables header guard checks as I proposed in Comment 3.

Comment 6 Shinichiro Hamaji 2010-02-24 00:52:00 PST

Comment on attachment 49360 [details]
Patch v1

Clearing flags on attachment: 49360

Committed r55184: <http://trac.webkit.org/changeset/55184>

Comment 7 Shinichiro Hamaji 2010-02-24 00:52:08 PST

All reviewed patches have been landed.  Closing bug.