Bug 34604

Summary: check-webkit-style false positive for WebCore forwarding header
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cjerdonek, eric, hamaji, levin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch v1 none

Geoffrey Garen
Reported 2010-02-04 10:56:53 PST
See bug 33383. WebCore forwarding headers have a special header guard style.
Attachments
Patch v1 (1.83 KB, patch)
2010-02-23 22:49 PST, Shinichiro Hamaji 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2010-02-04 11:00:44 PST
Thanks for the report!
David Levin
Comment 2 2010-02-04 11:19:35 PST
It looks like the rule here is if dir includes /([^/]*)/ForwardingHeaders/, then the header guard should be $1_FWD_NormalHeaderGuard
Shinichiro Hamaji
Comment 3 2010-02-16 03:52:04 PST
It seems JavaScriptCore/ForwardingHeaders/**/*.h, WebKit/mac/ForwardingHeaders/**/*.h, and WebKitTools/DumpRenderTree/ForwardingHeaders/**/*.h don't contain #ifndef guards. Maybe we can just silence build/header_guard for ForwardingHeaders? I'm not sure if it's worth to implement the check of $1_FWD_ style header guard only for WebCore.
Shinichiro Hamaji
Comment 4 2010-02-23 22:49:43 PST
Created attachment 49360 [details] Patch v1
Shinichiro Hamaji
Comment 5 2010-02-23 22:50:50 PST
> Patch v1 This patch just disables header guard checks as I proposed in Comment 3.
Shinichiro Hamaji
Comment 6 2010-02-24 00:52:00 PST
Comment on attachment 49360 [details] Patch v1 Clearing flags on attachment: 49360 Committed r55184: <http://trac.webkit.org/changeset/55184>
Shinichiro Hamaji
Comment 7 2010-02-24 00:52:08 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.