Bug 34602 – [GTK] Crashes when an invalid hostname is pre-fetched

• Component: Page Loading
• Status: RESOLVED FIXED

[Gustavo Noronha (kov)]

This is the console output:

(DumpRenderTree:19566): libsoup-CRITICAL **: soup_uri_host_hash: assertion `uri != NULL && uri->host != NULL' failed

(DumpRenderTree:19566): libsoup-CRITICAL **: soup_uri_copy_host: assertion `uri != NULL' failed

A snippet of the trace:

#0  0x00007ffff14536a5 in ?? () from /usr/lib/libsoup-2.4.so.1
#1  0x00007ffff145373a in soup_session_prepare_for_uri ()
   from /usr/lib/libsoup-2.4.so.1
#2  0x00007ffff6948ce9 in WebCore::prefetchDNS (hostname=...)
    at ../../WebCore/platform/network/soup/DNSSoup.cpp:46
#3  0x00007ffff637890d in WebCore::HTMLAnchorElement::parseMappedAttribute (
    this=0xa391e0, attr=0xa49890)
    at ../../WebCore/html/HTMLAnchorElement.cpp:282
#4  0x00007ffff62bdac6 in WebCore::StyledElement::attributeChanged (
    this=0xa391e0, attr=0xa49890, preserveDecls=false)
    at ../../WebCore/dom/StyledElement.cpp:190

The problem is SoupURI will give you a NULL URI if it is given an invalid URI, which is the case here.

[Gustavo Noronha (kov)]

Created attachment 48155 [details]
avoid crash

[WebKit Review Bot]

Attachment 48155 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/platform/network/soup/DNSSoup.cpp:41:  Use 0 instead of NULL.  [readability/null] [4]
Total errors found: 1


If any of these errors are false positives, please file a bug against check-webkit-style.

[Xan Lopez]

Comment on attachment 48155 [details]
avoid crash

I am Xan Lopez and I approve this patch.

[Gustavo Noronha (kov)]

(In reply to comment #2)
> Attachment 48155 [details] did not pass style-queue:
> 
> Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
> WebCore/platform/network/soup/DNSSoup.cpp:41:  Use 0 instead of NULL. 
> [readability/null] [4]
> Total errors found: 1

False-positive, reported here: https://bugs.webkit.org/show_bug.cgi?id=34605

[WebKit Commit Bot]

Comment on attachment 48155 [details]
avoid crash

Clearing flags on attachment: 48155

Committed r54359: <http://trac.webkit.org/changeset/54359>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.