Summary: | [WinCairo] Properly Handle Margin Settings | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> | ||||||
Component: | WebKit Misc. | Assignee: | Brent Fulgham <bfulgham> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Windows XP | ||||||||
Attachments: |
|
Description
Brent Fulgham
2010-02-03 16:13:56 PST
Created attachment 48077 [details]
Patch to correct handling of margins when printing.
Attachment 48077 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/win/WebFrame.cpp:2081: Extra space before ( in function call [whitespace/parens] [4]
WebKit/win/WebFrame.cpp:2082: Extra space before ( in function call [whitespace/parens] [4]
Total errors found: 2
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 48078 [details]
Revised patch, remove two extra spaces in function calls.
Comment on attachment 48078 [details] Revised patch, remove two extra spaces in function calls. > + cairoMarginRect.scale(1.0f / scale); You can just say "1 / scale" here. The 1 will get promoted to a float automatically. r=me Landed in http://trac.webkit.org/changeset/54356. |