Bug 34413

Summary: [BREWMP] Port ScriptController::createScriptInstanceForWidget
Product: WebKit Reporter: Kwang Yul Seo <skyul>
Component: WebCore JavaScriptAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Bug Depends on:    
Bug Blocks: 33564    
Attachments:
Description Flags
Patch none

Description Kwang Yul Seo 2010-02-01 02:28:05 PST
Port ScriptController::createScriptInstanceForWidget to BREWMP.
Comment 1 Kwang Yul Seo 2010-02-01 02:32:06 PST
Created attachment 47821 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-02-17 15:44:11 PST
Comment on attachment 47821 [details]
Patch

Why is this correct?  Does this match other implementations?  I've not stared at enough other implementations to know.
Comment 3 Kwang Yul Seo 2010-02-22 06:46:14 PST
(In reply to comment #2)
> (From update of attachment 47821 [details])
> Why is this correct?  Does this match other implementations?  I've not stared
> at enough other implementations to know.

Gtk, Haiku and Wx ports use the same code.
Comment 4 Eric Seidel (no email) 2010-02-22 13:02:23 PST
Comment on attachment 47821 [details]
Patch

OK.
Comment 5 WebKit Commit Bot 2010-02-23 00:26:19 PST
Comment on attachment 47821 [details]
Patch

Clearing flags on attachment: 47821

Committed r55126: <http://trac.webkit.org/changeset/55126>
Comment 6 WebKit Commit Bot 2010-02-23 00:26:23 PST
All reviewed patches have been landed.  Closing bug.