Bug 34413

Summary: [BREWMP] Port ScriptController::createScriptInstanceForWidget
Product: WebKit Reporter: Kwang Yul Seo <skyul>
Component: WebCore JavaScriptAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Bug Depends on:    
Bug Blocks: 33564    
Attachments:
Description Flags
Patch none

Kwang Yul Seo
Reported 2010-02-01 02:28:05 PST
Port ScriptController::createScriptInstanceForWidget to BREWMP.
Attachments
Patch (2.67 KB, patch)
2010-02-01 02:32 PST, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kwang Yul Seo
Comment 1 2010-02-01 02:32:06 PST
Created attachment 47821 [details] Patch
Eric Seidel (no email)
Comment 2 2010-02-17 15:44:11 PST
Comment on attachment 47821 [details] Patch Why is this correct? Does this match other implementations? I've not stared at enough other implementations to know.
Kwang Yul Seo
Comment 3 2010-02-22 06:46:14 PST
(In reply to comment #2) > (From update of attachment 47821 [details]) > Why is this correct? Does this match other implementations? I've not stared > at enough other implementations to know. Gtk, Haiku and Wx ports use the same code.
Eric Seidel (no email)
Comment 4 2010-02-22 13:02:23 PST
Comment on attachment 47821 [details] Patch OK.
WebKit Commit Bot
Comment 5 2010-02-23 00:26:19 PST
Comment on attachment 47821 [details] Patch Clearing flags on attachment: 47821 Committed r55126: <http://trac.webkit.org/changeset/55126>
WebKit Commit Bot
Comment 6 2010-02-23 00:26:23 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.